Skip to content

Remove L10 from test matrix #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Remove L10 from test matrix #541

merged 2 commits into from
Apr 7, 2025

Conversation

PeteBishwhip
Copy link
Member

This pull request includes a change to the GitHub Actions workflow configuration to update the test matrix for Laravel versions.

Changes in .github/workflows/run-tests.yml:

  • Removed support for Laravel 10.x from the test matrix.

@PeteBishwhip PeteBishwhip requested review from a team and Copilot April 4, 2025 11:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@SRWieZ
Copy link
Member

SRWieZ commented Apr 4, 2025

@PeteBishwhip
Copy link
Member Author

Not important but something to delete here too : https://github.com/NativePHP/laravel/blob/91f487cb40fdea5ce737fc7128f4f17dc2a2e92f/src/NativeServiceProvider.php#L53C2-L56C12

I left that in specifically because it also references L11. Do we not require it for 11?

@SRWieZ
Copy link
Member

SRWieZ commented Apr 4, 2025

The comment meant: we have to add the phpstan-ignore because this is backward compatible with L10.

I think the constructor did not have any parameters in L10 if I recall correctly.

@simonhamp
Copy link
Member

That FreshCommand is ours tho... why would we need to get phpstan to ignore? If we change the signature, we change the usages, no?

@PeteBishwhip
Copy link
Member Author

Lets check it. I'm going to remove the comment.

@SRWieZ
Copy link
Member

SRWieZ commented Apr 4, 2025

I don't recall exactly.

I remember putting this in because there was an error with PHPStan in L10, but L10 was working anyway.

@PeteBishwhip
Copy link
Member Author

@SRWieZ @simonhamp

Whats the use of this constructor argument?

image

My IDE is reporting its useless and following the trail back, I can't see where it's ever being used? Can this not be updated to not require a constructor arg?

@simonhamp
Copy link
Member

simonhamp commented Apr 4, 2025

L11 FreshCommand is the superclass of our FreshCommand

@simonhamp
Copy link
Member

L10 didn't have a constructor. So it looks like the PHPStan comment was to prevent L10 warnings.

I think we can remove the comment now. But we should leave the argument in place, as this will be required. Not sure why your IDE isn't picking it up...

@PeteBishwhip
Copy link
Member Author

Hah! Dev dependency issues! I see it now. Thanks.

@SRWieZ
Copy link
Member

SRWieZ commented Apr 4, 2025

All green

@PeteBishwhip PeteBishwhip requested a review from simonhamp April 4, 2025 16:01
@simonhamp simonhamp merged commit 9e9166d into main Apr 7, 2025
20 checks passed
@PeteBishwhip PeteBishwhip deleted the chore/remove-l10-support branch April 7, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants