-
-
Notifications
You must be signed in to change notification settings - Fork 187
Remove L10 from test matrix #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Not important but something to delete here too : |
I left that in specifically because it also references L11. Do we not require it for 11? |
The comment meant: we have to add the phpstan-ignore because this is backward compatible with L10. I think the constructor did not have any parameters in L10 if I recall correctly. |
That |
Lets check it. I'm going to remove the comment. |
I don't recall exactly. I remember putting this in because there was an error with PHPStan in L10, but L10 was working anyway. |
Whats the use of this constructor argument? My IDE is reporting its useless and following the trail back, I can't see where it's ever being used? Can this not be updated to not require a constructor arg? |
L11 |
L10 didn't have a constructor. So it looks like the PHPStan comment was to prevent L10 warnings. I think we can remove the comment now. But we should leave the argument in place, as this will be required. Not sure why your IDE isn't picking it up... |
Hah! Dev dependency issues! I see it now. Thanks. |
All green |
This pull request includes a change to the GitHub Actions workflow configuration to update the test matrix for Laravel versions.
Changes in
.github/workflows/run-tests.yml
: