Remove group packet filtering by replacing sli_zigbee_am_multicast_member
#112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0cd1723.
|
Firmware builds for those interested in trying them out: Unzip the ZIP files first. For SkyConnect/ZBT-1 users, upload the GBL file with the web flasher: https://connectzbt1.home-assistant.io/firmware-update/ |
This was referenced Apr 7, 2025
puddly
added a commit
to puddly/silabs-firmware-builder
that referenced
this pull request
Apr 9, 2025
…ember` (NabuCasa#112) * Revert "Disable "member of all groups" feature" This reverts commit 0cd1723. * Fix packet handoff group handling * Bump patch number to 2 * Cycle through the multicast table instead of using the first entry * Provide an interface for GCC linker `wrap` * Replace the stack function directly * Remove unused config * Only replace `wrapped_stack_functions` if it is present in the manifest * Update changelog
puddly
added a commit
that referenced
this pull request
Apr 10, 2025
* Revert "Gecko SDK 4.4.6 (#89)" for stable (#107) * Revert "Gecko SDK 4.4.6 (#89)" This reverts commit 18a0155. * Update OpenThread RCP firmware README * Bump the firmware patch number to 7.4.4.1 (#108) * Remove group packet filtering by replacing `sli_zigbee_am_multicast_member` (#112) * Revert "Disable "member of all groups" feature" This reverts commit 0cd1723. * Fix packet handoff group handling * Bump patch number to 2 * Cycle through the multicast table instead of using the first entry * Provide an interface for GCC linker `wrap` * Replace the stack function directly * Remove unused config * Only replace `wrapped_stack_functions` if it is present in the manifest * Update changelog * Reapply "Gecko SDK 4.4.6 (#89)" for stable (#107) This reverts commit 420fa6b. * Drop patch number override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a packet filter callback, replace the EmberZNet-internal
sli_zigbee_am_multicast_memberfunction with a no-op. This prevents the stack from filtering out the packets we are interested in and is a much lighter-weight approach compared to using a packet filter callback to inject ephemeral entries into the group table. The downside here is API stability but this will be visible when upgrading the SDK.For background, Zigbee has three ways for messages to be sent: unicast (device-to-device), broadcast (device-to-everything), and multicast (device-to-group). Group messages are used by some IKEA devices and remotes to be able to control light bulbs directly from sensors, without using a coordinator in the mesh. The SDK unfortunately requires you to explicitly register a group ID to un-ignore the group, which is not really possible when there are 2^16 of them. This PR bypasses the SDK function responsible for filtering out these messages.