Make ACME reset more error tolerant #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
reviewed
Jan 20, 2022
| @@ -409,6 +407,7 @@ async def reset_acme(self) -> None: | |||
| self._acme_client = None | |||
| self._account_jwk = None | |||
| self._x509 = None | |||
| await self.cloud.run_executor(self._remove_files) | |||
There was a problem hiding this comment.
We should only with suppress the execution of the function above and run after it this
There was a problem hiding this comment.
The problem is we don't really know what errors we get, isn't it better to log?
emontnemery
force-pushed
the
improve_acme_reset
branch
from
8c42d7b to
1a1da08
Compare
pvizeli
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ACME reset more error tolerant: