Do not block at startup #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Jan 19, 2022
22 tasks
balloob
reviewed
Jan 20, 2022
balloob
approved these changes
Jan 20, 2022
Co-authored-by: Paulus Schoutsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud.initializerefreshes the access token (if needed) and waits untilRemoteUIis connected, which will block for a very long time if we're not connected to the network.This changes such that we return before the potentially long-running network access to allow HA core to initialize cloud when there's no network, access token refresh and remote connection is handed off to a task.
To synchronize completion of initialization, it's possible to register
on_initializedcallbacks.