Skip to content

Atomic writes, chmod and more logging #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 4, 2020
Merged

Atomic writes, chmod and more logging #162

merged 6 commits into from
Jun 4, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 3, 2020

  • Add missing chmod that got lost in Add a safe write method #155
  • Use atomic write for writing cert too
  • Add timeout when calling challenge cleanup
  • Add more debug logging to remote initialization

@balloob balloob changed the title One more atomic write Atomic writes, chmod and more logging Jun 3, 2020
MartinHjelmare
MartinHjelmare reviewed Jun 4, 2020
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 3a5be8e into master Jun 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the one-more-atomic-write branch June 4, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @MartinHjelmare