Use a single listener for all timeout fixture invocations #12426
+67
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
|
build |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the timeout listener setup used in integration tests to employ a single static listener instance, improving resource utilization and consistency.
- The Python test initialization now sets global defaults and initializes the singleton listener.
- The Java listener has been refactored to use static fields and includes a static initializer and unregister logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| integration_tests/src/main/python/spark_init_internal.py | Introduces global default timeout settings and adjusts the timeout fixture to use these defaults. |
| integration_tests/src/main/java/org/apache/spark/rapids/tests/TimeoutSparkListener.java | Refactors TimeoutSparkListener into a singleton with static fields and methods to manage listener registration and timeout settings. |
integration_tests/src/main/java/org/apache/spark/rapids/tests/TimeoutSparkListener.java
Outdated
Show resolved
Hide resolved
…TimeoutSparkListener.java Co-authored-by: Copilot <[email protected]>
razajafri
reviewed
Apr 2, 2025
integration_tests/src/main/java/org/apache/spark/rapids/tests/TimeoutSparkListener.java
Show resolved
Hide resolved
integration_tests/src/main/java/org/apache/spark/rapids/tests/TimeoutSparkListener.java
Outdated
Show resolved
Hide resolved
|
build |
Signed-off-by: Gera Shegalov <[email protected]>
|
build |
|
CI hitting SIGSEGV which affects other PRs is unrelated |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12413
Resolves #12408
staticVerified that the number of threads grows linearly without this PR and stays flat with this PR using