Remove Compare/Combined modes from Profiling tool #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#1582 Cleanup processApp to use better scope of variables Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> createAppAndProcess should not take a Seq Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fix qualX code removing appIndex Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
amahussein
added
feature request
There was a problem hiding this comment.
Copilot reviewed 40 out of 60 changed files in this pull request and generated no comments.
Files not reviewed (20)
- core/src/main/scala/com/nvidia/spark/rapids/tool/EventLogPathProcessor.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AppIndexMapperTrait.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AppSQLPlanAnalyzer.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AppSparkMetricsAggTrait.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AppSparkMetricsAnalyzer.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/CompareApplications.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/CompareSummaryInfo.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/GenerateDot.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/HealthCheck.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileArgs.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileClassWarehouse.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileMain.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileOutputWriter.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/Profiler.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualSQLPlanAnalyzer.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/Qualification.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/tuning/TunerContext.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/views/AggMetricsResultSorter.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/views/AppStageMetricsView.scala: Language not supported
- core/src/main/scala/com/nvidia/spark/rapids/tool/views/DataSourceView.scala: Language not supported
github-actions
bot
added
user_tools
|
@leewyang can you please take to the changes in Python? @wjxiz1992 FYI, this PR removes appIndex column from the CSV files. |
sayedbilalbari
approved these changes
Apr 8, 2025
| @@ -1,3 +0,0 @@ | |||
| appIndex,jobId,numTasks,Duration,diskBytesSpilled_sum,duration_sum,duration_max,duration_min,duration_avg,executorCPUTime_sum,executorDeserializeCPUTime_sum,executorDeserializeTime_sum,executorRunTime_sum,input_bytesRead_sum,input_recordsRead_sum,jvmGCTime_sum,memoryBytesSpilled_sum,output_bytesWritten_sum,output_recordsWritten_sum,peakExecutionMemory_max,resultSerializationTime_sum,resultSize_max,sr_fetchWaitTime_sum,sr_localBlocksFetched_sum,sr_localBytesRead_sum,sr_remoteBlocksFetched_sum,sr_remoteBytesRead_sum,sr_remoteBytesReadToDisk_sum,sr_totalBytesRead_sum,sw_bytesWritten_sum,sw_recordsWritten_sum,sw_writeTime_sum | |||
| 1,0,213,2569,0,26735,1598,10,125.5,6608,3531,12095,13414,0,0,336,0,0,0,0,8,8075,0,2600,80279908,0,0,0,80279908,80279908,2600,1001 | |||
There was a problem hiding this comment.
Why has this test file been removed ? I am assuming this has to do with the removed compare mode test
There was a problem hiding this comment.
The removed files used to represent the combined view of multiple eventlogs.
Since those unit tests are removed there is no need to keep those expected CSV files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1582
Removes the two modes (compare/combine). This yields to removal of AppIndex column from all the output files.
This pull request includes several changes to the
coremodule, primarily focusing on removing redundant parameters and simplifying the codebase. The most significant changes involve the removal of theappIndexparameter from various methods and classes.appIndex_1was renamed topropertyValue.appIndexcolumn was removed.Codebase simplification:
appIndexparameter from thelogApplicationInfomethod inEventLogPathProcessorand several methods and classes inAppSQLPlanAnalyzerandAppSparkMetricsAnalyzer. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Trait adjustments:
ProfAppIndexMapperTraitby extendingQualAppIndexMapperTraitinstead of implementing its own method.These changes collectively aim to streamline the code and remove unnecessary complexity.