-
Notifications
You must be signed in to change notification settings - Fork 44
Qualx unit tests #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualx unit tests #1599
Conversation
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
Signed-off-by: Lee Yang <[email protected]>
2badf0e
to
43a724f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
For the eventlogs:
- can we put a script or a readme to show steps on how to reproduce those eventlogs?
- For gpu-eventlog: this is important as we might need to generate the eventlog as the RAPIDS plugin evolves.
-
Can we cleanup the Qualx warnings? There is an open issue for that [BUG] Reduce noise from Qualx logs #1535 . Those messages are heard to read and they pretty much show up everytime.
WARNING: Imputing missing features: ['fraction_supported', 'platform_databricks-aws', 'platform_databricks-azure', 'platform_dataproc', 'platform_emr', 'sqlOp_BatchEvalPython', 'sqlOp_CartesianProduct', 'sqlOp_CommandResult', 'sqlOp_CustomShuffleReader', 'sqlOp_DeserializeToObject', 'sqlOp_Execute InsertIntoHadoopFsRelationCommand csv', 'sqlOp_Execute InsertIntoHadoopFsRelationCommand json', 'sqlOp_Execute InsertIntoHadoopFsRelationCommand orc', 'sqlOp_Execute InsertIntoHadoopFsRelationCommand parquet', 'sqlOp_Execute InsertIntoHadoopFsRelationCommand text', 'sqlOp_Execute InsertIntoHadoopFsRelationCommand unknown', 'sqlOp_Generate', 'sqlOp_GenerateBloomFilter', 'sqlOp_GlobalLimit', 'sqlOp_HashAggregatePrefixGroupingSets', 'sqlOp_LocalLimit', 'sqlOp_MapElements', 'sqlOp_ObjectHashAggregate', 'sqlOp_OutputAdapter', 'sqlOp_PartialWindow', 'sqlOp_ReusedSort', 'sqlOp_RunningWindowFunction', 'sqlOp_Scan ExistingRDD', 'sqlOp_Scan ExistingRDD Delta Table Checkpoint', 'sqlOp_Scan ExistingRDD Delta Table State', 'sqlOp_Scan OneRowRelation', 'sqlOp_Scan csv', 'sqlOp_Scan jdbc', 'sqlOp_Scan json', 'sqlOp_Scan orc', 'sqlOp_Scan text', 'sqlOp_Scan unknown', 'sqlOp_SerializeFromObject', 'sqlOp_SortAggregate', 'sqlOp_SubqueryOutputBroadcast', 'sqlOp_TakeOrderedAndProject', 'sqlOp_WindowSort']
WARNING: Removing extra features: ['hasSqlID', 'jobStartTime_min', 'resourceProfileId', 'sqlOp_GpuBroadcastExchange', 'sqlOp_GpuBroadcastHashJoin', 'sqlOp_GpuBroadcastNestedLoopJoin', 'sqlOp_GpuCoalesceBatches', 'sqlOp_GpuColumnarExchange', 'sqlOp_GpuColumnarToRow', 'sqlOp_GpuCustomShuff
When preprocessing the event logs # tests/spark_rapids_tools_e2e/features/steps/preprocess_steps.py:84 6.913sn parquet', 'sqlOp_GpuShuffleCoalesce', 'sqlOp_GpuShuffledHashJoin', 'sqlOp_GpuSort', 'sqlOp_GpuTopN', 'sqlOp_GpuWindow']
…t sample eventlogs Signed-off-by: Lee Yang <[email protected]>
@amahussein thanks for the review. I added a short README.md describing that these eventlogs were basically obtained from our As for cleaning up the warnings, I think we should keep that separate from this PR (which is solely focused on the testing side). Feel free to assign that other bug to me, if needed. Simplest thing would be to change most of those warnings to debug logs. |
9868176
to
17a86b2
Compare
Signed-off-by: Lee Yang <[email protected]>
17a86b2
to
49c7413
Compare
That sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leewyang
LGTME
This PR adds some basic unit tests for qualx.
Notes: