Skip to content

Fix AutoTuner unit test with dynamic plugin JAR URL value #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

parthosa
Copy link
Collaborator

This PR fixes a unit test added in PR #1578.

The AutoTuner recommendation included recommending the latest plugin JAR which is a dynamic property. This PR introduces helper methods to fetch the latest plugin JAR URL and use that in the recommendation.

@parthosa parthosa added bug Something isn't working core_tools Scope the core module (scala) labels Mar 14, 2025
@parthosa parthosa self-assigned this Mar 14, 2025
Copy link
Collaborator

@sayedbilalbari sayedbilalbari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parthosa parthosa merged commit a11ce36 into NVIDIA:dev Mar 14, 2025
15 checks passed
@parthosa parthosa deleted the spark-rapids-tools-plugin-ver-ut-fix branch March 14, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants