Add stringType and binaryType to the list of dataType map #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#1492 Adds 2 new entries to the dataTypes map defined in the PluginTypeChecker - string: varchar, car - binary: blob
amahussein
commented
Jan 22, 2025
| case "int" => Seq("integer") | ||
| case "long" => Seq("bigint") | ||
| case "short" => Seq("smallint") | ||
| case "string" => Seq("varchar", "char") |
There was a problem hiding this comment.
string and binary are 2 new rows.
The rest of changes in rows were due to order the entries alphabetically.
amahussein
changed the title
parthosa
approved these changes
Jan 22, 2025
cindyyuanjiang
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #1492
Adds 2 new entries to the dataTypes map defined in the PluginTypeChecker