-
Notifications
You must be signed in to change notification settings - Fork 44
Sync plugin support as of 2024-12-31 #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync plugin support as of 2024-12-31 #1478
Conversation
Signed-off-by: cindyyuanjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang for working on that.
It is important to stay up-to-date with the plugin since many of the new operators are affecting our customers.
I updated the issue description with the latest sync-pugin job. So, will be nice to include the remaining execs/expression if they are easy to knock off.
core/src/test/resources/QualificationExpectations/read_dsv1_expectation.csv
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: cindyyuanjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTME. Minor comment in the test suite.
core/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang
Signed-off-by: cindyyuanjiang <[email protected]>
54f75be
I updated this PR to have a parametrized unit test for testing expressions supported in ProjectExec. cc: @parthosa @amahussein |
Signed-off-by: cindyyuanjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang
I like the new tests! Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang. LGTME.
Fixes #1452
This PR syns plugin support as of 2024-12-31.
The changes include: