Jwilber/evo2 generate patch #949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
…he call Signed-off-by: John St John <[email protected]>
Signed-off-by: Jared Wilber <[email protected]>
- NeMo: f17dbf74d (Anton's hyena changes + seq_len_interpolation_factor) - Megatron-LM: 5fc4f681 (Anton's inference context fixes) - Based on bionemo-compatible versions (6a78ab8 and fb7c3f8)
jwilber
requested review from
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jstjohn,
malcolmgreaves,
pstjohn,
skothenhill-nv,
trvachov,
sichu2023,
jomitchellnv and
cspades
as code owners
Signed-off-by: Jared Wilber <[email protected]>
added 2 commits
June 18, 2025 16:40
Signed-off-by: Jared Wilber <[email protected]>
Signed-off-by: Jared Wilber <[email protected]>
farhadrgh
requested changes
Jun 23, 2025
There was a problem hiding this comment.
Is the plan to merge this PR into main, or will it remain a feature branch without merging? CC: @trvachov
I’ve noticed that this PR is undoing some of the improvements we previously applied to the NeMo implementation in hyena_utils and hyena_mixer, particularly regarding memory overhead (e.g., unnecessary variable creation and excessive tensor rearrangements).
We should not merge this PR into main until these issues are addressed. Merging as-is would complicate future NeMo upgrades and prevent us from leveraging cuHyena efficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incompatibility between the Megatron/NeMi-based implementation of hyena operators in BioNeMo and the original Vortex kernels used for generation. Namely, add in Vortex's stateful convolution logic used during inference, based on a previous migration from @antonvnv.
Type of changes
Usage
Pre-submit Checklist