Skip to content

Bump protobuf to 5.29.5 #14045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

Bump protobuf to 5.29.5 #14045

merged 1 commit into from
Jun 28, 2025

Conversation

chtruong814
Copy link
Collaborator

What does this PR do ?

Bump protobuf to 5.29.5

Collection: [Note which collection this PR will affect]

Changelog

  • Bump protobuf to 5.29.5

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Charlie Truong <[email protected]>
@chtruong814 chtruong814 added r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 Run CICD labels Jun 27, 2025
@github-actions github-actions bot removed the Run CICD label Jun 28, 2025
@chtruong814
Copy link
Collaborator Author

The failing test is a known failure. Will go ahead and merge.

@chtruong814 chtruong814 merged commit d47145a into main Jun 28, 2025
555 of 561 checks passed
@chtruong814 chtruong814 deleted the chtruong/bump-protobuf branch June 28, 2025 20:37
ko3n1g pushed a commit that referenced this pull request Jun 28, 2025
Signed-off-by: Charlie Truong <[email protected]>
chtruong814 added a commit that referenced this pull request Jun 29, 2025
Signed-off-by: Charlie Truong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r2.4.0 Pick this label for auto-cherry-picking into r2.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants