Adds a built stage for the trt-llm wheel to reduce the overall test image size #12883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
chtruong814
requested review from
pablo-garay,
ko3n1g and
thomasdhc
as code owners
ko3n1g
approved these changes
Apr 4, 2025
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
rrbale-nvidia
pushed a commit
to rrbale-nvidia/NeMo
that referenced
this pull request
Apr 11, 2025
…mage size (NVIDIA#12883) * Add trt-llm build stage for docker Signed-off-by: Charlie Truong <[email protected]> * Fix syntax error in reintall.sh Signed-off-by: Charlie Truong <[email protected]> * Fix trt-llm install Signed-off-by: Charlie Truong <[email protected]> * debug Signed-off-by: Charlie Truong <[email protected]> * Fix trt llm args in docker build Signed-off-by: Charlie Truong <[email protected]> * Fix trt-llm args in docker build Signed-off-by: Charlie Truong <[email protected]> * Fix install of trt-llm Signed-off-by: Charlie Truong <[email protected]> * Fix install of trt-llm Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: Ritvik Bale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds a built stage for the trt-llm wheel to reduce the overall test image size.
When I built this manually, the size reduced from ~90gb to ~70gb. Our official nemo container uncompressed is ~60gb. So better but probably can be more efficient.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information