Skip to content

Alit/test coverage #12762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 26, 2025
Merged

Alit/test coverage #12762

merged 13 commits into from
Mar 26, 2025

Conversation

JRD971000
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@JRD971000 JRD971000 force-pushed the alit/test_coverage branch from 611727c to 62ddcdc Compare March 25, 2025 13:23
@github-actions github-actions bot added the CI label Mar 25, 2025
JRD971000 and others added 3 commits March 25, 2025 14:30
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Ali Taghibakhshi <[email protected]>
@JRD971000 JRD971000 force-pushed the alit/test_coverage branch from ba95b12 to 73b1f53 Compare March 25, 2025 14:41
@JRD971000 JRD971000 self-assigned this Mar 25, 2025
@JRD971000 JRD971000 enabled auto-merge (squash) March 25, 2025 14:58
@pablo-garay
Copy link
Collaborator

approved from CI perspective

Copy link
Contributor

[🤖]: Hi @JRD971000 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@github-actions github-actions bot removed the Run CICD label Mar 26, 2025
@JRD971000 JRD971000 merged commit 70c136a into main Mar 26, 2025
422 of 603 checks passed
@JRD971000 JRD971000 deleted the alit/test_coverage branch March 26, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants