Skip to content

docs: Update installation guides #12596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 14, 2025
Merged

docs: Update installation guides #12596

merged 12 commits into from
Mar 14, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Mar 13, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ko3n1g added 3 commits March 13, 2025 14:02
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g self-assigned this Mar 13, 2025
ko3n1g added 7 commits March 13, 2025 14:47
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g requested a review from ericharper March 13, 2025 14:03
f
Signed-off-by: oliver könig <[email protected]>
README.md Outdated
- Conda / Pip - Refer to [Conda](#conda) and [Pip](#pip) for
installation instructions.
- [Conda / Pip](#conda--pip): Install NeMo-Framework with native Pip into a virtual environment.
- Perfect to explore NeMo on any supported platform.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect sounds optimistic, maybe "Used"

README.md Outdated
instructions.
- Limited feature-completeness for other domains.
- [NGC PyTorch container](#ngc-pytorch-container): Install NeMo-Framework from source with feature-completeness into a highly optimized container.
- Perfect for customers that seek flexibility.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again let's use another word besides "perfect". Also flexibility is a bit generic. Maybe just say what it is. For users that want to install from source in a highly optimized container.

README.md Outdated
- Perfect for customers that seek flexibility.
- Provides most flexibility for container of your choice.
- [NGC NeMo container](#ngc-nemo-container): Ready-to-go solution of NeMo-Framework
- Perfect for customers that seek highest performance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use perfect. And replace customers -> users

README.md Outdated
- Provides most flexibility for container of your choice.
- [NGC NeMo container](#ngc-nemo-container): Ready-to-go solution of NeMo-Framework
- Perfect for customers that seek highest performance.
- Insides all dependencies and NeMo libraries such as NeMo-Aligner, NeMo-Curator, and more.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention that the container contains all dependencies installed and tested for performance and convergence

README.md Outdated
NeMo-Framework provides tiers of support based on OS / Platform and mode of installation. Please refer the following overview of support levels:

- Fully supported: Max performance and feature-completeness.
- Limited supported: Perfect to explore NeMo.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's change it

README.md Outdated

Please refer to the following table for current support levels:

| OS / Platform | Pip-install | Source into NGC container |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pip-install is a bit ambiguous. Let's use Install from PyPi or something like that.

README.md Outdated

```bash
conda install pytorch torchvision torchaudio pytorch-cuda=11.8 -c pytorch -c nvidia
pip install "nemo_toolkit"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? Don't we need "nemo_toolkit[all]" or a specific domain? Also can we switch to "nemo_framework" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, nemo_toolkit works but it's probably too lightweight.


To install the nemo_toolkit, use the following installation method:
If a more specific version is desired, we recommend a Pip-VCS install. From [NVIDIA/NeMo](github.com/NVIDIA/NeMo), fetch the commit, branch, or tag that you would like to install.
To install nemo_toolkit from this Git reference `$REF`, use the following installation method:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nemo_framework

Comment on lines +376 to +381
pip install nemo_toolkit['all'] # or pip install "git+https://github.com/NVIDIA/NeMo@${REF:-'main'}#egg=nemo_toolkit[all]"
pip install nemo_toolkit['asr'] # or pip install "git+https://github.com/NVIDIA/NeMo@$REF#egg=nemo_toolkit[asr]"
pip install nemo_toolkit['nlp'] # or pip install "git+https://github.com/NVIDIA/NeMo@${REF:-'main'}#egg=nemo_toolkit[nlp]"
pip install nemo_toolkit['tts'] # or pip install "git+https://github.com/NVIDIA/NeMo@${REF:-'main'}#egg=nemo_toolkit[tts]"
pip install nemo_toolkit['vision'] # or pip install "git+https://github.com/NVIDIA/NeMo@${REF:-'main'}#egg=nemo_toolkit[vision]"
pip install nemo_toolkit['multimodal'] # or pip install "git+https://github.com/NVIDIA/NeMo@${REF:-'main'}#egg=nemo_toolkit[multimodal]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nemo_framework ?

README.md Outdated
--shm-size=16g \
--ulimit memlock=-1 \
--ulimit stack=67108864 \
nvcr.io/nvidia/pytorch:${NV_PYTORCH_TAG:-'nvcr.io/nvidia/nemo:24.12'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.12?

Signed-off-by: oliver könig <[email protected]>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ko3n1g ko3n1g merged commit 4ee21bc into main Mar 14, 2025
30 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/docs/pip-installable branch March 14, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants