Skip to content

Fix packed seq shift when using answer only loss #12415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

cuichenx
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix incorrect shift when using answer only loss

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Chen Cui <[email protected]>
@github-actions github-actions bot added the NLP label Feb 28, 2025
@cuichenx
Copy link
Collaborator Author

linting issues are with the nemo 1 files which will be deprecated soon. The equivalent nemo 2 file have these issues already fixed

@ryanleary
Copy link
Contributor

If we verify that this resolves the convergence issue, can we please add some unit testing around the loss mask generation? Ideally we'd add that testing as well as some short convergence test around the recipe.

@cuichenx
Copy link
Collaborator Author

If we verify that this resolves the convergence issue, can we please add some unit testing around the loss mask generation? Ideally we'd add that testing as well as some short convergence test around the recipe.

good idea! I can do that

Copy link
Contributor

[🤖]: Hi @cuichenx 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@chtruong814 chtruong814 merged commit 067ca8f into main Feb 28, 2025
199 of 349 checks passed
@chtruong814 chtruong814 deleted the chcui/fix-packed-seq-shift branch February 28, 2025 17:18
ko3n1g added a commit that referenced this pull request Feb 28, 2025
* cherrypick 12415

Signed-off-by: Chen Cui <[email protected]>

* cherrypick 12424

Signed-off-by: Chen Cui <[email protected]>

* cherrypick 12382

Signed-off-by: Chen Cui <[email protected]>

* build: Pin `texterrors` (#12417)

* build: Pin `texterrors`

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>

* update test since packed data now has loss mask 0 for eos tokens

Signed-off-by: Chen Cui <[email protected]>

* Apply isort and black reformatting

Signed-off-by: cuichenx <[email protected]>

* fix import and use new `ParallelLinearAdapter`

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Co-authored-by: cuichenx <[email protected]>
Agoniii pushed a commit to Agoniii/NeMo that referenced this pull request Mar 6, 2025
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: Xue Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants