Skip to content

ci: Bump Mcore in weekly PR #11897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

ci: Bump Mcore in weekly PR #11897

merged 1 commit into from
Jan 20, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 20, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g marked this pull request as ready for review January 20, 2025 10:07
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner January 20, 2025 10:07
@ko3n1g ko3n1g merged commit aa4f9fb into main Jan 20, 2025
17 of 19 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/chore/bump-weekly branch January 20, 2025 10:07
@github-actions github-actions bot added the CI label Jan 20, 2025
@ko3n1g ko3n1g restored the ko3n1g/chore/bump-weekly branch January 20, 2025 10:09
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
@ko3n1g ko3n1g deleted the ko3n1g/chore/bump-weekly branch February 8, 2025 22:01
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant