-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-disk storage & single stride size #48
Open
density215
wants to merge
142
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lsm_tree dep * persistence_key calculation * weave PREFIX_SIZE and KEY_SIZE into CustomAllocStorage * PersisTree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very large PR, you'd better look at the resulting code in the source
dev
branch, than at the diffed code from the PR.Major changes are:
MemoryOnly
: current records are stored in memory only. New records replace existing records.PersistOnly
: current records are persisted to disk only. New records replace existing records.PersistHistory
: current records are stored in memory only. Existing records are stored on disk, when a newer record is written.WriteAhead
: current records are stored both in memory and persisted to disk. Existing records are stored on disk, when a newer record is written.src/lib.rs
has more details, that's also a good starting point to get a grip on the whole repo.Rotonda-store 0.2
resulted in this number being the best performing size for all data structures involved, in both memory consumption and speed. This also vastly simplified the code, and reduces the amount of indirections needed to go from stride to stride.