Introduce Octets trait using GATs and drop OctetsRef. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
added a commit
that referenced
this pull request
May 12, 2023
Breaking Changes * Drop the `OctetsRef` trait and introduce a new `Octets` trait that takes over its purpose. This requires Rust 1.65.0. ([#12]) * Change the signature of `Octets::range` to use a range and drop all the convenience methods. ([#13]) * Split conversion from an octets builder to an immutable octets sequence off of `OctetsBuilder` to the new `FreezeBuilder` trait. ([#25]) * Dropped the `len` and `is_empty` methods from the `OctetsBuilder` trait. These can be requested via `AsRef<[u8]>` if necessary. ([#20]) * Rearranged module structure: * broke up `traits` into `octets` and `builder`, * renamed `types` to `array`, and * moved `SmallOctets` to `octets`. ([#18]) * The integer parsing methods on `Parser` have been renamed to make it clear they parse big-endian integers and new methods for parsing little-endian integers have been added. ([#35]) * The optional traits `SerializeOctets` and `DeserializeOctets` have been redesigned for greater flexibility. ([#21]) New * Added `Parser::parse_parser` that allows parsing a given number of octets and return them as a cloned parser. ([#10]) * Add methods to `Parser` to parse 64 and 128 bit integers. ([#11]) * Added support for the `heapless` crate. ([#19]) * Added missing `Octets` implementation for `Array<N>`. ([#29]) * Added `Octets` implementation for `Arc<[u8]>`. ([#28]) * Added blanket implementations for `OctetsBuilder` and `Truncate` for mutable references of types that are `OctetsBuilder` and `Truncate`, respectively. ([#30]) * Added conversions from `&str` and `&[u8]` to `Str<[u8]>`. ([#31]) * Added `Array::resize_raw`. ([#32], [#33])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the traits to use the soon-to-be-stabilized generic associated types aka GATs. It drops the
OctetsReftrait and all its related weirdness in favor of a simpleOctetstrait. This new trait serves the same purpose but is implemented by the octets sequence type itself rather than a reference to it.