Skip to content

[JOSS 6532] Expand and clarify contribution guidlines #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfm opened this issue Apr 22, 2024 · 3 comments · Fixed by #20
Closed

[JOSS 6532] Expand and clarify contribution guidlines #19

dfm opened this issue Apr 22, 2024 · 3 comments · Fixed by #20

Comments

@dfm
Copy link

dfm commented Apr 22, 2024

One of the JOSS review requirements is that submissions have clear contribution guidelines, but I couldn't find them documented for JAXBind. This should probably include developer docs and info about issue/PR expectations, for example.

ref: openjournals/joss-reviews#6532

@Edenhofer
Copy link
Contributor

Thanks for your comment! Is #20 sufficient or shall the contributions guide be more detailed?

@dfm
Copy link
Author

dfm commented Apr 22, 2024

I'd say that that does satisfy the letter of the JOSS requirements, but perhaps doesn't present the most welcoming face to new developers. I leave it up to you to decide if this is sufficient for your purposes!

@Edenhofer
Copy link
Contributor

Thanks! You're right. The section reads really grumpy. I probably woke up on the wrong side of the bed yesterday 😬

Hope it reads much friendlier now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants