Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hiroara @NEWROPE/dev
I tried to deal upgrade
serialize-javascript
: GHSA-hxcc-f52p-wc94 andkind-of
: GHSA-6c8f-qphg-qjgpUnfortunately, those depend on
rollup-plugin-uglify
, which is almost not maintained: TrySound/rollup-plugin-uglify#87The author recommends using
rollup-plugin-terser
instead: TrySound/rollup-plugin-uglify#69-> I replaced
rollup-plugin-uglify
withrollup-plugin-terser
in this PR.Unfortunatelykind-of
is still blocked because ofchokidar-cli
: https://github.com/kimmobrunfeldt/chokidar-cli - but this package is not maintained well, and also only used for local development -> I decided not to pursue thekind-of
upgrade further.Please review.