Skip to content

Add ID tutorial + fix CI bug #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 22, 2023
Merged

Add ID tutorial + fix CI bug #121

merged 13 commits into from
Dec 22, 2023

Conversation

Vittorio-Caggiano
Copy link
Collaborator

  • Add an Inverse Dynamics tutorial (contributed by @andreh1111)
  • Fix CI bug on MacOs

andreh1111 and others added 11 commits November 26, 2023 20:54
No need to use ctrl for rendering, mjVIS_ACTIVATION (flag in position 5) has this purpose
osqp was already the used solver from before, but the installation of qpsolvers also involve other methods, as scs, which dependencies are not found for macOS. osqp is therefore now used directly.
robot_int -> robot_init
object_int -> object_init
only these files had this difference
Add tutorial 6_Inverse_Dynamics
ubuntu/windows-latest: unchanged
macos-latest (separated workflow file):
- shell without login (otherwise the used python version is not the requested one)
- source conda before env activation (this step is required if shell is without login)
- export SYSTEM_VERSION_COMPAT=0 before conda activate, taken from google-deepmind/mujoco#1004
The implementation is different w.r.t. the previous commit, but the focus is the same, and the obtained workflow is more similar to the original version.
Note: setting "python-version: 3.8" in miniconda setup  for ubuntu-latest result in "mujoco.FatalError: gladLoadGL error", even if "MUJOCO_GL=egl" is set as env variable.
Fix workflow for PR integration
fix myodm names of data keys from _int to _init
@Vittorio-Caggiano Vittorio-Caggiano added bug Something isn't working documentation Improvements or additions to documentation labels Dec 7, 2023
andreh1111 and others added 2 commits December 17, 2023 11:06
Tutorial 6_ID: added filter on qfrc to avoid oscillatory activations
Copy link
Collaborator

@vikashplus vikashplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vittorio-Caggiano Vittorio-Caggiano merged commit 5f1aa16 into main Dec 22, 2023
ttktjmt pushed a commit to ttktjmt/myosuite that referenced this pull request Feb 12, 2025
Add ID tutorial + fix CI bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants