-
Notifications
You must be signed in to change notification settings - Fork 125
Add ID tutorial + fix CI bug #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vittorio-Caggiano
commented
Dec 7, 2023
- Add an Inverse Dynamics tutorial (contributed by @andreh1111)
- Fix CI bug on MacOs
No need to use ctrl for rendering, mjVIS_ACTIVATION (flag in position 5) has this purpose
osqp was already the used solver from before, but the installation of qpsolvers also involve other methods, as scs, which dependencies are not found for macOS. osqp is therefore now used directly.
robot_int -> robot_init object_int -> object_init only these files had this difference
Add tutorial 6_Inverse_Dynamics
ubuntu/windows-latest: unchanged macos-latest (separated workflow file): - shell without login (otherwise the used python version is not the requested one) - source conda before env activation (this step is required if shell is without login) - export SYSTEM_VERSION_COMPAT=0 before conda activate, taken from google-deepmind/mujoco#1004
The implementation is different w.r.t. the previous commit, but the focus is the same, and the obtained workflow is more similar to the original version. Note: setting "python-version: 3.8" in miniconda setup for ubuntu-latest result in "mujoco.FatalError: gladLoadGL error", even if "MUJOCO_GL=egl" is set as env variable.
Fix workflow for PR integration
fix myodm names of data keys from _int to _init
Tutorial 6_ID: added filter on qfrc to avoid oscillatory activations
vikashplus
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ttktjmt
pushed a commit
to ttktjmt/myosuite
that referenced
this pull request
Feb 12, 2025
Add ID tutorial + fix CI bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.