Skip to content

Update PyProject Toml - License #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

robinjhuang
Copy link
Contributor

Hey! HaoHao from comfy.org again 😊.

As a heads up, the license field is optional but in the case that it is filled out, the license file should be referenced either by the file path or by the name of the license.

  • license = { file = "LICENSE" }
  • license = {text = "MIT License"}
  • license = "LICENSE"
  • license = "MIT LICENSE"

This was brought up in our discord and so we're creating a small PR to update that optional field. For more info check out toml file standards or our docs page!

@MrForExample MrForExample merged commit 124bdbc into MrForExample:main Aug 28, 2024
@vgpavon
Copy link

vgpavon commented Aug 29, 2024

Hello,

I encountered several issues while trying to install the ComfyUI-3D-Pack from your repository.

Errors logged to 'H:\Program Files\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-3D-Pack\ComfyUI-3D-Pack.git\lfs\logs\20240829T183707.9508056.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: Checkpoints/CharacterGen/2D_Stage/models/checkpoint/scaler.pt: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Here’s a summary of the main problems:

Git LFS Smudge Filter Failed:

The process failed to checkout files managed by Git LFS, specifically scaler.pt. This issue was consistent even after retrying with git lfs fetch --all and git lfs checkout.
Git LFS Data Quota Exceeded:

The repository has exceeded its Git LFS data quota, preventing the download of necessary large files. The error message suggests purchasing more data packs to restore access.
Submodule Configuration Challenges:

While attempting to add the repository as a submodule, there were issues related to embedded Git repositories, leading to potential misconfiguration.
These issues are blocking the installation and usage of the ComfyUI-3D-Pack. It would be greatly appreciated if you could address the Git LFS quota issue or provide alternative access to the required files.

Thank you for your assistance.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants