Skip to content

download button added #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

download button added #216

merged 1 commit into from
Jul 16, 2024

Conversation

yashschandra
Copy link
Contributor

To download glb or other model files loaded in the visualizer, otherwise we have to copy file from server's output folder.

Screen.Recording.2024-07-13.at.9.45.00.PM.mov

@MrForExample If this PR looks ok then can you please test it once locally. I tested it on my local machine with some workarounds in place (because macos 😞 )

@MrForExample MrForExample merged commit 66ea8b2 into MrForExample:main Jul 16, 2024
@MrForExample
Copy link
Owner

MrForExample commented Jul 16, 2024

Thank you for your contribution 👍
@yashschandra Do you think you can find a way to make sure it downloads with correct extension name? (.obj, .glb)

@yashschandra
Copy link
Contributor Author

@MrForExample it already downloads with correct extension, checked with .glb and .obj files

@8-unlimit
Copy link

Thank you for your contribution!!!!!!
When my comfyui is not deployed locally, it will not be displayed normally.
I have added client IP in configs/system.conf file.
Do you have this problem? Thanks 🙇‍

@WorkSync
Copy link

WorkSync commented Jul 30, 2024

To download glb or other model files loaded in the visualizer, otherwise we have to copy file from server's output folder.

Screen.Recording.2024-07-13.at.9.45.00.PM.mov
@MrForExample If this PR looks ok then can you please test it once locally. I tested it on my local machine with some workarounds in place (because macos 😞 )

Hello, thank you for your great contribution. I wonder how to right-click the node, and then download in the menu, then how should I implement it?
Specifically, it is in the folder--"web/scripts/app.js",and code --"node.prototype.getExtraMenuOptions = function (_, options)".

@yashschandra
Copy link
Contributor Author

Thank you for your contribution!!!!!! When my comfyui is not deployed locally, it will not be displayed normally. I have added client IP in configs/system.conf file. Do you have this problem? Thanks 🙇‍

Hello @QianquanChina I never had to configure any IPs in the conf file. I have always hosted ComfyUI on a normal vm instance behind an nginx server.

@yashschandra
Copy link
Contributor Author

To download glb or other model files loaded in the visualizer, otherwise we have to copy file from server's output folder.
Screen.Recording.2024-07-13.at.9.45.00.PM.mov
@MrForExample If this PR looks ok then can you please test it once locally. I tested it on my local machine with some workarounds in place (because macos 😞 )

Hello, thank you for your great contribution. I wonder how to right-click the node, and then download in the menu, then how should I implement it? Specifically, it is in the folder--"web/scripts/app.js",and code --"node.prototype.getExtraMenuOptions = function (_, options)".

@WorkSync I never though of doing it like that but I think that would be better than just adding a button. Did you figure out any way to implement it? I haven't looked at it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants