-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JEI config support #83
Conversation
Configured doesn't know how to convert records like |
Yeah, that is a drawback of my implementation here. Here are some improvements that I think Configured could implement later to improve support for JEI's configs:
|
I may be able to expose the string serialization and deserialization in JEI's API somehow. |
I have updated this PR, and now it uses new features of JEI's API to implement |
I have updated the PR to use the latest JEI version, which exposes configs much earlier. |
Everything checks out. Merging now. Thanks for your work into making these mods compatible again. |
Hey @mezz, I am currently relicensing Configured. I want to change the mod to be under a more appropriate license of LGPLv3. |
Hello! You have my permission to relicense my changes to Configured under LGPLv3 👍 |
Thank you! |
I added some methods to JEI's API so that Configured can get the config information without reflection.
This should make the compatibility much more stable, since JEI does not change the API much.
There are some regressions here, like Configured does not understand myrecord
values.I added some extra support for enums in lists, but I wasn't able to make it use a selector like with regular enum values.Despite the drawbacks, I hope this is a good clean starting point at least.Update: I have added full support for serializing and deserializing these values in the configs.