Skip to content

PIRATES #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

PIRATES #2142

wants to merge 6 commits into from

Conversation

StiffRobot
Copy link

@StiffRobot StiffRobot commented May 30, 2025

About The Pull Request

Rakshari get the pirate accent by default now
Also they can be swashbucklers
Also also they can be sand pirates
Unrelated but knocking on doors has a cooldown again, didn't wanna make a whole new pr for that
grafik
grafik
grafik

Why It's Good For The Game

Accent was requested by Ook, swashbuckler seemed fine to me, desert rider adds more variety/flavour to rakshari, otherwise they only get the Zybantine Merc

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

min_pq = 0
category_tags = list(CTAG_MERCENARY)

cmode_music = 'sound/music/cmode/unused/combat_desertrider.ogg'
Copy link

@SmokingCrackForChrist SmokingCrackForChrist May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use this song, any-other one will do so long as it's not in the unused folder - CombatOutlander was made to channel that kind of energy if you need a recommendation!

Might also recommend giving them an extra point in PER if they're going to be using ranged weapons. Love this PR btw

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if I pull it out of that folder? I can use another track if preferred though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if I pull it out of that folder? I can use another track if preferred though.

To give some context, early-on in this codebase I decided to keep the old songs we needed to axe in the code as something neat for people to stumble on if they ever looked into it. We cannot use anything in unused as nobody sought permission to use them, and now we kinda need to give them the proper axe looking back on it. It's a great song and that's why it's still left in the code, we just can't use it

You can use whatever track you like outside of the codebase so long as it conforms to the asset license CC BY-SA 3.0. I would recommend FreeMusicArchive, you can search directly for the applicable license on the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants