-
Notifications
You must be signed in to change notification settings - Fork 186
PIRATES #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PIRATES #2142
Conversation
min_pq = 0 | ||
category_tags = list(CTAG_MERCENARY) | ||
|
||
cmode_music = 'sound/music/cmode/unused/combat_desertrider.ogg' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use this song, any-other one will do so long as it's not in the unused folder - CombatOutlander was made to channel that kind of energy if you need a recommendation!
Might also recommend giving them an extra point in PER if they're going to be using ranged weapons. Love this PR btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if I pull it out of that folder? I can use another track if preferred though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if I pull it out of that folder? I can use another track if preferred though.
To give some context, early-on in this codebase I decided to keep the old songs we needed to axe in the code as something neat for people to stumble on if they ever looked into it. We cannot use anything in unused as nobody sought permission to use them, and now we kinda need to give them the proper axe looking back on it. It's a great song and that's why it's still left in the code, we just can't use it
You can use whatever track you like outside of the codebase so long as it conforms to the asset license CC BY-SA 3.0. I would recommend FreeMusicArchive, you can search directly for the applicable license on the link
About The Pull Request
Rakshari get the pirate accent by default now



Also they can be swashbucklers
Also also they can be sand pirates
Unrelated but knocking on doors has a cooldown again, didn't wanna make a whole new pr for that
Why It's Good For The Game
Accent was requested by Ook, swashbuckler seemed fine to me, desert rider adds more variety/flavour to rakshari, otherwise they only get the Zybantine Merc
Pre-Merge Checklist