Skip to content

Even betterer soil updates #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025
Merged

Conversation

CheffieGithub
Copy link
Collaborator

@CheffieGithub CheffieGithub commented May 30, 2025

About The Pull Request

Soil only updates every 10 seconds or when it matures, dies, is ready for harvest, is harvested, or uprooted.

We don't need to really care about when weeds appear or health hits the threshold to change colour immediately because in reality 10 seconds won't make much of a difference there.

Why It's Good For The Game

I merged the other pr too early so I made it better.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@CheffieGithub CheffieGithub marked this pull request as ready for review May 30, 2025 09:58
@CheffieGithub CheffieGithub merged commit b9f89f2 into Monkestation:main Jun 12, 2025
8 checks passed
StiffRobot pushed a commit to StiffRobot/Vanderlin that referenced this pull request Jun 13, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- Note: PRs including balance changes authored by anyone other than
maintainers and official devs will not be considered. -->

## About The Pull Request
Soil only updates every 10 seconds or when it matures, dies, is ready
for harvest, is harvested, or uprooted.

We don't need to really care about when weeds appear or health hits the
threshold to change colour immediately because in reality 10 seconds
won't make much of a difference there.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review or prevent the PR from being merged!
-->

## Why It's Good For The Game
I merged the other pr too early so I made it better.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Pre-Merge Checklist
<!-- Don't bother filling these in while creating your Pull Request,
just click the checkboxes after the Pull Request is opened and you are
redirected to the page. -->
- [ ] You tested this on a local server.
- [ ] This code did not runtime during testing.
- [ ] You documented all of your changes.
<!-- Neither the compiler nor workflow checks are perfect at detecting
runtimes and errors. It is important to test your code/feature/fix
locally. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant