Skip to content

OOC pronouns on hover #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 3, 2025

Conversation

flleeppyy
Copy link
Member

@flleeppyy flleeppyy commented Jun 21, 2025

About The Pull Request

Adds pronouns that users can set in game preferences to display in OOC when they speak.
Players can choose from a predefined list of pronouns. As much as I would like to allow any pronouns, it's not a risk I'm willing to take because someone will not use it for pronouns

image
image

Why It's Good For The Game

Pronouns yes. QoL.

Changelog

🆑
add: OOC pronouns
/:cl:

@flleeppyy flleeppyy requested a review from Absolucy June 21, 2025 22:29
@flleeppyy flleeppyy added Feature: Feature The creature feature. featuring: the creature. QoL improves quality of life Process: should testmerge PR should be testmerged first labels Jun 21, 2025
Absolucy
Absolucy previously approved these changes Jun 21, 2025
@Absolucy Absolucy dismissed their stale review June 21, 2025 22:56

fix unit test failures (wtf?)

@ThePooba
Copy link
Collaborator

mrrp mrrrrp

@Absolucy Absolucy dismissed their stale review June 22, 2025 19:13

review addressed

@ThePooba ThePooba added the Approval: admin approved PR is approved by admins label Jun 23, 2025
@flleeppyy
Copy link
Member Author

Will be adding hovers in a few more places, so don't merge yet.

@ThePooba ThePooba merged commit 2052fc9 into Monkestation:master Jul 3, 2025
27 checks passed
github-actions bot added a commit that referenced this pull request Jul 3, 2025
CheffieGithub added a commit to Monkestation/Vanderlin that referenced this pull request Jul 12, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

## About The Pull Request

Makes Vanderlin more woke by porting the pronouns/body selector from
Azure Peak, and OOC pronouns from Monkestation

This is for a [bounty in the Monkestation
Discord](https://canary.discord.com/channels/748354466335686736/1392272358731026473)
by cocokailey

> either a port or a remake of the azure peak body type selector , voice
type selector and pronoun selector.
> 
> A few caveats
> 
> Kobolds must be locked to it/its
> Only Kobolds and Halfkin will be allowed to use it/its
> They/Them, She/Her and He/Him for all other races and Halfkin.
> 
> Reward 5 dollah + 50 triumphs to be paid out on the 28th this month as
thats when I get paid.

The caveats have been followed and species datums now have an
`allowed_pronouns` list
Ports:
- GeneralPantsuIsBadAtCoding/Azure-Peak#19
- Monkestation/Monkestation2.0#7036

There was also requested functionality for additional species specific
body types to be added, but I do not sprite, so that will not be added
in this PR, but the base for adding more body types are there. I ported
OOC pronouns to compensate for the fact I cannot sprite.

## Why It's Good For The Game

Bounty! also i don't play vanderlin so I don't know how or why this
would be good for the game. but, uh, better character customization?

## Pre-Merge Checklist
<!-- Don't bother filling these in while creating your Pull Request,
just click the checkboxes after the Pull Request is opened and you are
redirected to the page. -->
- [x] You tested this on a local server.
- [x] This code did not runtime during testing.
- [x] You documented all of your changes.
<!-- Neither the compiler nor workflow checks are perfect at detecting
runtimes and errors. It is important to test your code/feature/fix
locally. -->

# Changelog
- You can now change your character's pronouns and voice type.
- - The available pronouns are: she/her, he/him, they/them, it/its
- - - Only kobolds and half/hollow-kin can use it/its. Kobolds are
forced to use it/its.
- - The available voice types are: Masculine, Feminine, Androgynous
- - - We do not have an androgynous voice pack, so we compensate by
using the female voice pack, pitch multiplied by 0.92 to achieve a more
androgynous tone.
- Randomizing your character now prompts you if you really want to
randomize, with the option of "Don't Ask Again This Round (Yes)"
- You can now change your OOC pronouns via the verb `Set OOC Pronouns`
- - Admins can ban users from setting ooc pronouns
- Adds tooltips and conditional tooltips.
- - Usage: `span_tooltip(tip, main_text)`
- - Usage to show tooltip with condition:
`conditional_tooltip(normal_text, tooltip_text, condition)`

<img width="396" height="95" alt="image"
src="https://github.com/user-attachments/assets/0c51d8f2-f52a-4d84-9510-5ce959e87969"
/>

<img width="208" height="206" alt="image"
src="https://github.com/user-attachments/assets/0d1db857-3d2d-4a41-ac55-d94bbbc39cf9"
/>

---------

Co-authored-by: grungussuss <[email protected]>
Co-authored-by: CheffieGithub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approval: admin approved PR is approved by admins Feature: Feature The creature feature. featuring: the creature. Process: should testmerge PR should be testmerged first QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants