-
Notifications
You must be signed in to change notification settings - Fork 349
Port rebar #6769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port rebar #6769
Conversation
This has... a lot of pretty bad changes? Left click cycling the crossbow isn't QOL - it's evaporating a massive part of the skill required to use the weapon. The syndicate quiver fitting on the neck is dumb too - chose the belt slot instead, it's like that on teegee iirc cause the guy that pred it had a specific loadout using an infiltrator suit and so he wanted to have his cake and eat it too. (and fuck that it should work normally). But then you also make the projectiles really slow for some reason which - on a server with sprinting so a high movespeed, AND on a low magazine slow reload alpha strike weapon would just kill it. Leave the cycling (the equivalent of racking the bolt were you using a mosin) unchanged, don't touch the projectile speed, change the syndie quiver from neck slot (so stupid it's even a thing on teegee) to belt slot and this would probably be fairly solid. |
Also the numbers you lifted from how they are on teegee don't seem to do the same thing here that they do there. Which is why the bolt speed numbers are so horrifyingly slow. |
Hi, I'm the guy. The reason why I moved the quiver to the neck slot, was precisely because engineers (the guys that are supposed to be using this weapon) usually have their belt slot occupied by their actual belt, and if you did want to use the infiltrator suit the alternative was carrying a storage box sorely dedicated to the bolts. The quiver and the left click to reload only exist to make the weapon less janky to use, they don't change how powerful the weapon is in the hands of a competent player, and I'm a firm believer jank shouldn't be a replacement for game balance. I don't play monkee so I legit have no idea of how this would fit in your echo system, but my from my understanding, everything is way more powercrept than it is on TG, so maybe that's fine? |
icon_state = "syndie_quiver_0" | ||
if(1 to 7) | ||
icon_state = "syndie_quiver_1" | ||
if(8 to 13) | ||
icon_state = "syndie_quiver_2" | ||
if(14 to 20) | ||
icon_state = "syndie_quiver_3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon_state = "syndie_quiver_0" | |
if(1 to 7) | |
icon_state = "syndie_quiver_1" | |
if(8 to 13) | |
icon_state = "syndie_quiver_2" | |
if(14 to 20) | |
icon_state = "syndie_quiver_3" | |
icon_state = "syndie_quiver_0" | |
if(1 to 7) | |
icon_state = "syndie_quiver_1" | |
if(8 to 13) | |
icon_state = "syndie_quiver_2" | |
if(14 to 20) | |
icon_state = "syndie_quiver_3" |
wouldn't it be better to have base_icon_state = "syndie_quiver"
on the typepath, and then have these like icon_state = "[base_icon_state]_0"
user.balloon_alert(user, "no bolts left!") | ||
return | ||
var/obj/held_item = user.get_active_held_item() | ||
if(!held_item || !istype(held_item, /obj/item/gun/ballistic/rifle/rebarxbow)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(!held_item || !istype(held_item, /obj/item/gun/ballistic/rifle/rebarxbow)) | |
if(!istype(held_item, /obj/item/gun/ballistic/rifle/rebarxbow)) |
it wouldn't be that type if it was null anyways
if(!magazine) | ||
. += "[initial(icon_state)]" + "_empty" | ||
if(!bolt_locked) | ||
. += "[initial(icon_state)]" + "_bolt_locked" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be better to define and use a base_icon_state
instead of using initial(icon_state)
?
This reverts commit 14fa3a1.
i love rebar crossbow |
About The Pull Request
Brings changes from the following PRs:
tgstation/tgstation#86116 : Bolt rebalance
tgstation/tgstation#86116 : Also rebalances
tgstation/tgstation#86116 : Syndicate variant of quiver
tgstation/tgstation#82830 : Makes the bowstring actually rack when fired
Why It's Good For The Game
Changelog
🆑
add: A Syndicate Rebar Quiver has been added to the uplink
qol: Left clicking with a rebar crossbow will now draw/undraw the string.
/:cl: