[PORT] Stabilizes code that flicks overlays to view/all clients #6631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather then using images and displaying them with client.images, we can instead simply make an object, give it the passed in image/MA's appearance, and then vis_contents it where we want. If you want to animate things, you can just use the atom we return from the proc call. This ends up costing about 25% of the best case scenario (one guy online) It will save more time with more users, but it also allows us to avoid the hypersuffering that is passing GLOB.clients into the flick proc. So I think I'm happy enough with this. For context, here's average per call cost for flick_overlay_view() right now. It winds between 5e-5 and 1e-4. With these changes we should pretty consistently hit the low end of this, because none of our work really varies all that much.  (I was using sswardrobe for this, but it ends up being a lot slower so like, why yaknow) ``` /atom/movable/flick_visual New: 3.65625ms Provide: 7.4375ms Qdel: 9.4375ms Stash: 9.46875ms ``` Using our tools should not make your code eat cpu time for no reason. Hearers is expensive, iterating clients is expensive, let's not be expensive.
## About The Pull Request #76937 introduced a temporary movable `flick_visual` to act as an image for overlays and whatnot. this used to be handled by images and i'm not sure whether images were mouse transparent or were just inheriting parent ID but i'm assuming since images are kinda virtual (from what i know anyway) they don't interrupt clicks. since flick_visual is an atom, it intercepts mouse clicks, which caused #77142 this PR gives flick_visual `MOUSE_OPACITY_TRANSPARENT` during `flick_overlay_view()`, which makes it no longer intercept clicks ## Why It's Good For The Game Fixes #77142 and possibly some other things that use that proc to show animations or overlays
Absolucy
added
the
Code: Performance / Optimization
This was referenced May 10, 2025
This was referenced May 11, 2025
This was referenced May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#76937 and tgstation/tgstation#77155
Why It's Good For The Game
better performance meow
Changelog
no user-facing changes