Skip to content

[PORT] Weapons that cannot fit into turrets also cannot fit into emitters, adds a blacklist to turrets #6551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RandomDudeFromTheRim
Copy link
Contributor

@RandomDudeFromTheRim RandomDudeFromTheRim commented May 3, 2025

About The Pull Request

Ports tgstation/tgstation#90960 AND tgstation/tgstation#75263
Weapons that cannot fit into turrets can not fit into emitters. This only affects the dueling pistol as of writing.
Adds a global list of gun types banned from being added to turrets. Adds dueling pistols to the banned list as they can freely round remove people when in turrets without the usual restrictions.

Why It's Good For The Game

Instakill turrets/emitters are an undesirable outcome.
Prevents this:
image
or if you want a more descriptive example, this:

born.in.matrix.mp4

Changelog

🆑
fix: Weapons that cannot fit into turrets also cannot fit into emitters.
fix: Dueling pistols can no longer be fitted in turrets to instantly kill people.
/:cl:

@RandomDudeFromTheRim
Copy link
Contributor Author

oh

@RandomDudeFromTheRim RandomDudeFromTheRim marked this pull request as draft May 3, 2025 19:32
@RandomDudeFromTheRim RandomDudeFromTheRim marked this pull request as ready for review May 3, 2025 20:00
@RandomDudeFromTheRim
Copy link
Contributor Author

RandomDudeFromTheRim commented May 3, 2025

This is weird, build.cmd doesn't yell at me yet, the energy_gun is used in other things in the code, yet it complains HERE. Please help if possible!

@RandomDudeFromTheRim RandomDudeFromTheRim changed the title [PORT] Weapons that cannot fit into turrets also cannot fit into emitters. [PORT] Weapons that cannot fit into turrets also cannot fit into emitters, adds a blacklist to turrets May 3, 2025
@Absolucy Absolucy added the Code: Fix fix da bug label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Fix fix da bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants