Fix some odd edge-cases with head/face protection #6523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
Code: Fix
This was referenced Apr 30, 2025
This was referenced May 1, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This refactors
/mob/living/carbon/is_mouth_covered,/mob/living/carbon/is_eyes_covered, and/mob/living/carbon/is_pepper_proofto check ALL slots for the desired protection.If a mask has the
HEADCOVERSMOUTHflag, it will still count as covering their mouth like a helmet would.The first example I could think of is the damned rabbit mask - it had
HEADCOVERSMOUTH, and the examine would say it would protect against facehuggers, but it does not.Why It's Good For The Game
bugfix
Changelog
🆑
fix: Fixed some weird edge cases with helmets/masks/etc that are supposed to cover your eyes or mouth.
fix: The Damned Rabbit Mask now actually blocks facehuggers like the examine says it should.
/:cl: