UI scaling fixes for 516 (+ command bar typing indicators) #6280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was another boolean that was used to just manage stuff codeside that really was not accessed _too_ much and is ultimately not useful as a variable on `/mob`. This just moves it to a trait because it's only really used in a few spots for a similar intent+purpose. Less stuff to deal with in the average view variables window whenever looking at a mob, which is really nice and welcome. Doesn't concern players.
## About The Pull Request It was very specifically broken by [this commit](tgstation/tgstation@94d00aa), because it wrongfully changed the logic. Now the typing indicator is back, it's no longer just the thinking indicator. ## Why It's Good For The Game Typing indicator is meant to be there, now it's back! No more awkward flickering! ## Changelog :cl: GoldenAlpharex fix: The typing indicator has overcome its shyness and is now back to its usual form. /:cl:
changes a whole load of crap in the skin to make it a bit more reactive to sizing changes, and thus to high dpi monitors this required adding a bunch of splitters - these have a sane preset for most monitors but if you ever need to edit it, it's hidden under the chat settings 1920x1080, 100% scaling  4k, 200% scaling before:  after:  the sliders: [user-attachments/assets/776730a7-a325-4b3b-8e27-15636828c6d4](https://github.com/user-attachments/assets/776730a7-a325-4b3b-8e27-15636828c6d4) it makes the game a bit more playable on my laptop :cl: qol: under the chat settings, you can now press "Adjust UI Sizes" to drag around some of the panel sizes fix: the input at the bottom right is no longer so teeny tiny on 516 if you use a window scaling that is greater than 100% /:cl: --------- Co-authored-by: harryob <[email protected]>
…erence for smaller windows (#90418) various uis (tgui-say, vv, player panel, anything using `/datum/browser`) would not correct for dpi. they now do we also have a preference to allow you to have smaller windows that are zoomed out, instead of larger windows that are not zoomed viewport units, like `vh` and `vw`. they need to be fed through the `vp(100vw)` function first. there was only one such unit in the codebase on 4k monitor with 200% scaling: fixed (pref on default)  pref disabled  516 fucked with uis again and this unfucks them a bit :cl: qol: there's a new UI preference called UI scale which allows people that use windows scaling to have their UIs original size with the contents zoomed out, instead of the default, which is the UIs being larger with the contents "normal" size fix: various UIs did not respect windows scaling, they now do /:cl: --------- Co-authored-by: harryob <[email protected]>
Absolucy
added
Code: Fix
This was referenced Apr 12, 2025
This was referenced Apr 13, 2025
Open
This was referenced Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs:
thinking_ICvariable to a trait tgstation/tgstation#80122Changelog
🆑
add: (MTO, Lilah Novi) Say commands typed in the command bar now trigger typing indicators.
qol: (hry-gh) Under the chat settings, you can now press "Adjust UI Sizes" to drag around some of the panel sizes.
fix: (hry-gh) The input at the bottom right is no longer so teeny tiny on 516 if you use a window scaling that is greater than 100%
qol: (hry-gh) There's a new UI preference called UI scale which allows people that use windows scaling to have their UIs original size with the contents zoomed out, instead of the default, which is the UIs being larger with the contents "normal" size.
fix: (hry-gh) Various UIs did not respect windows scaling, they now do.
fix: Fixed the white border around the tgui-say input on 516 when it was focused.
/:cl: