Skip to content

Base implementation of /datum/persistent_client #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Apr 9, 2025

About The Pull Request

Ports the following PRs from tg:

Converts /datum/player_details into /datum/persistent_client.
Persistent Clients persist across connections. The only time a mob's persistent client will change is if the ckey it's bound to logs into a different mob, or the mob is deleted (duh).

Also adds PossessByPlayer() so that transfering mob control is cleaner and makes more immediate sense if you don't know byond-fu.

Why It's Good For The Game

Clients are an abstract representation of a connection that can be dropped at almost any moment so putting things that should be stable to access at any time onto an undying object is ideal. This allows for future expansions like abstracting away client.screen and managing everything cleanly.

Changelog

No player-facing changes

@Absolucy Absolucy added Process: do not merge don't merge this ffs Feature: Refactor/Rework Completely redoing a larger thing / recoding a thing Process: should testmerge PR should be testmerged first labels Apr 9, 2025
@github-actions github-actions bot added the Merge Conflict DO NOT RENAME THIS LABEL label Apr 12, 2025
@Absolucy Absolucy merged commit 65e432d into Monkestation:master Apr 14, 2025
25 checks passed
@Absolucy Absolucy deleted the persisting-my-client branch April 14, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor/Rework Completely redoing a larger thing / recoding a thing Process: do not merge don't merge this ffs Process: should testmerge PR should be testmerged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant