the average house cat can hit a top speed of around 30 miles per hour #6243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
the
Code: Performance / Optimization
This was referenced Apr 7, 2025
Closed
## About The Pull Request According to Kapu, RscFile() is a hash operation and thus is relatively slow. Having dozens of them ran every tick by atmos tanks is not ideal. There's more uncached icons in filters to tackle but the only one relatively impactful is status display init mask - however our filter code is mildly fucked to say the least, as icon() is ran ***regardless of whenever a filter is cached or not*** because we pass them as lists, not actual filter objects - and filter() seems to call one internally regardless of what its passed, so every update_filters fetches an icon for anything with an alpha/displacement filter. This doesn't actually do much on its own, but is nice to have so that future contributors don't make the same mistake by copypasting code. ## Changelog :cl: SmArtKar, Kapu fix: Atmospheric tanks no longer fetch icons every tick /:cl:
…nt CI fails (#88413) ## About The Pull Request Fixes #71092 ## Why It's Good For The Game Flaky tests bad, fixman good... ## Changelog :cl: fix: Pubby's whiteship no longer breaks when it tries to dock /:cl:
…nt/ai_movement/Recover()` to avoid runtime spam
## About The Pull Request turns out there's _zero_ cooldown on sending messages to MMI. which can. uh. lead to an unpleasant experience.  so i added a 1 second cooldown. simple enough. ## Why It's Good For The Game this shit nearly crashes my game ## Changelog :cl: fix: Messages sent to MMIs in wiremod components now have a 1 second cooldown, to prevent massive spam. /:cl:
## About The Pull Request Mech code is ass, projectiles_per_shot is 1 by default so honkerblast was trying to fire nonexistent projectiles in its parent call and runtimed, preventing target logging (Paddy claw does this correctly) ## Changelog :cl: fix: Fixed a Honkerblast 5000 runtime /:cl:
## About The Pull Request  ## Why It's Good For The Game its faster i think ## Changelog :cl: code: basicmobs that delete on death, ghost before dying /:cl:
This was referenced Apr 8, 2025
This was referenced Apr 8, 2025
… more-performance-shit
This always expects to return a list, even if empty. But this early returned before the parent call, meaning it didn't return the empty list (from parent) as expected. :cl: Melbert fix: Fixed an error from reading an ID card closely when you can't read /:cl:
… more-performance-shit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
look i didn't want to name this PR another variant of "some more performance tweaks", okay?
Ports the following PRs:
/datum/mind/Destroy()tgstation/tgstation#90456to_chatnever actually queuing tgstation/tgstation#90461Changelog
🆑
fix: Optimized some more stuff, reducing the potential for server-side lag (time dilation) in some situations.
fix: Chat messages now actually queue as intended.
fix: Fixed improperly cleaning up memories when a mind is deleted.
fix: Messages sent to MMIs in wiremod components now have a 1 second cooldown, to prevent massive spam.
code: (mc-oofet) Basic mobs that delete on death now ghost before dying.
fix: (SmArtKar, Kapu) Atmospheric tanks no longer fetch icons every tick
fix: (tontyGH) Pubby's whiteship no longer breaks when it tries to dock.
fix: (SmArtKar) Fixed a Honkerblast 5000 runtime.
fix: (Melbert) Fixed an error from reading an ID card closely when you can't read.
/:cl: