Skip to content

[PORT] scss cleanup and some chat things #6171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 4, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Apr 1, 2025

About The Pull Request

Ports tgstation/tgstation#90336

Changelog

🆑 Absolucy, Kashargul
fix: confirm buttons on the chat window
fix: scroll tracking failing on large display counts when large messages blocks where received
/:cl:

@Absolucy Absolucy added Process: do not merge don't merge this ffs Code: Fix fix da bug Process: should testmerge PR should be testmerged first Code: TGUI Involves TGUI in some way, shape or form labels Apr 1, 2025
@Absolucy Absolucy added Process: do not testmerge 50-50 chance this gets testmerged anyways and removed Process: should testmerge PR should be testmerged first labels Apr 1, 2025
@Absolucy Absolucy added Process: do not merge don't merge this ffs Process: should testmerge PR should be testmerged first and removed Process: do not merge don't merge this ffs Process: do not testmerge 50-50 chance this gets testmerged anyways labels Apr 2, 2025
@Absolucy Absolucy removed the Process: do not merge don't merge this ffs label Apr 4, 2025
@Absolucy Absolucy merged commit 07a92cd into Monkestation:master Apr 4, 2025
25 checks passed
@Absolucy Absolucy deleted the chatstuff branch April 4, 2025 01:35
github-actions bot added a commit that referenced this pull request Apr 4, 2025
github-merge-queue bot pushed a commit to cmss13-devs/cmss13 that referenced this pull request Apr 8, 2025
# About the pull request
Updates typescript to the latest version 5.8.2

Moves button confirm from the secondary click event to blur for the
reset

Also porting the scroll node searching from
Monkestation/Monkestation2.0#6171 which should
add some more reliability if the history was loading too slowly

Additionally, porting the removal of all polyfills:
tgstation/tgstation#90397
Splitting of tgui html:
tgstation/tgstation#90340

Adding the changes to tgui say from
tgstation/tgstation#90418

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Fix fps / tick config not applying individually
ui: Buttons now use blur to reset
ui: Fix tgsay not scaling correctly when using small scale option
ui: Fix edgecase with chat scrolling sometimes breaking when loading in
large chat history
code: Bump typescript version for tgui
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Fix fix da bug Code: TGUI Involves TGUI in some way, shape or form Process: should testmerge PR should be testmerged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant