Skip to content

Fix inputs on BYOND 516 getting cut off (tgui payload chunking) #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 31, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Mar 28, 2025

About The Pull Request

Ports tgstation/tgstation#90295

Dream Seeker will not send topic calls greater than 2kb in size. There are cases where tgui will attempt to send ui_act payloads larger than this, such as writing on paper. This PR takes payloads that would be larger than 2kb, splits them into payloads that would be roughly 1kb (after URL encoding), and sends them to the server in sequence. To prevent abuse and/or topic spam, a config option has been added to put a limit on the number of chunks for which the server will accept a payload, defaulting to 10.

Why It's Good For The Game

Fixes (tg issue 90056), along with several other things that were affected by the change to WebView2 in 516.

Changelog

🆑 Absolucy, Y0SH1M4S73R
code: Any tgui message that would be too big to send to the server is now split into chunks and sent in sequence. This fixes several issues, such as...
fix: It is once again possible to save large amounts of text on paper at once.
/:cl:

@Absolucy Absolucy added Process: do not merge don't merge this ffs Code: Fix fix da bug Process: should testmerge PR should be testmerged first Code: TGUI Involves TGUI in some way, shape or form labels Mar 28, 2025
Y0SH1M4S73R and others added 2 commits March 29, 2025 13:04
@Absolucy Absolucy merged commit 1396c8e into Monkestation:master Mar 31, 2025
5 checks passed
@Absolucy Absolucy deleted the 516-payload-fix branch March 31, 2025 23:54
github-actions bot added a commit that referenced this pull request Mar 31, 2025
This was referenced Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Fix fix da bug Code: TGUI Involves TGUI in some way, shape or form Process: should testmerge PR should be testmerged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants