Ports tgui ticket panel from yogs #5906

adamsong · 2025-03-12T02:07:30Z

About The Pull Request

Ports yogs tgui ticket panel, plus a little bit of the rest of yog's ticket system that the panel relies on.

Why It's Good For The Game

Having to constantly click refresh is annoying

Changelog

🆑
add: Added tgui ticket panel
/:cl:

michaelyoungin · 2025-03-12T02:09:14Z

PELASE POOBERT I BEG OF YOU

LikeLakers2 · 2025-03-12T08:27:00Z

Marking as awaiting admin review, as I assume they'd want to review it first.

LikeLakers2 · 2025-03-12T08:31:22Z

code/modules/admin/sql_message_system.dm

@@ -94,15 +94,15 @@
 		VALUES (:type, :target_ckey, :admin_ckey, :text, [timestamp? ":timestamp" : "Now()"], :server, INET_ATON(:internet_address), :port, :round_id, :secret, :expiry, :note_severity, (SELECT `minutes` FROM [format_table_name("role_time")] WHERE `ckey` = :target_ckey AND `job` = 'Living'))
 	"}, parameters)
 	var/pm = "[key_name(usr)] has created a [type][(type == "note" || type == "message" || type == "watchlist entry") ? " for [target_key]" : ""]: [text]"
-	var/header = "[key_name_admin(usr)] has created a [type][(type == "note" || type == "message" || type == "watchlist entry") ? " for [target_key]" : ""]"
+	var/header = "[usr.key] has created a [type][(type == "note" || type == "message" || type == "watchlist entry") ? " for [target_key]" : ""]"


I wouldn't do this, as the use of key_name_admin gives more info (or inserts *no key* if there's no key attached, rather than simply leaving a blank space).

key_name_admin also adds html tags, which are then sanitized by tgui and displayed

you can use dangerouslySetInnerHTML or decodeHtmlEntities

key_name_admin also adds html tags, which are then sanitized by tgui and displayed

Still, the way you have it leaves a blank space if there's no key attached - which can lead to confusion.

I can just do key_name, it does the same thing without the html tags

LikeLakers2 · 2025-03-12T08:32:25Z

code/modules/admin/topic.dm

-		exportable_text += "[special_role_description]<br>"
-		exportable_text += ADMIN_FULLMONTY_NONAME(subject)
-
-		to_chat(src.owner, boxed_message(exportable_text), confidential = TRUE)


I would highly recommend commenting out these lines of code, instead of removing them. It makes porting efforts easier.

LikeLakers2 · 2025-03-12T08:32:51Z

code/modules/admin/verbs/admin.dm

-	message_admins(msg)
+	var/msg = "[key_name(usr)] made [key_name(M)] drop everything!"
+	log_admin(msg)
+	message_admins("[key_name_admin(usr)] made [ADMIN_LOOKUPFLW(M)] drop everything!")


Why are you reordering lines here, and in so many other places too?

Makes the code a bit better, log_admin and admin_ticket_log getting the same message, w/o html tags, and then message_admins gets the tags, so I needed to move the definition of msg above the log_admin

LikeLakers2 · 2025-03-12T08:35:26Z

code/modules/admin/verbs/adminhelp.dm

+	// dat += "</html>"
+
+	// usr << browse(dat.Join(), "window=ahelp[id];size=750x480")
+	// MONKESTATION EDIT END


A little tip: DM supports /* */ for block comments. It's much easier to just use that, than to prepend // onto every line.

Its not that much easier than telling vs code to block comment, but I can see how it would make porting stuff easier, so I'll convert it to a block

LikeLakers2 · 2025-03-12T08:36:35Z

code/modules/cargo/centcom_podlauncher.dm

@@ -808,7 +808,7 @@
 	message_admins("[key_name_admin(usr)] [msg] in [ADMIN_VERBOSEJMP(specificTarget)].")
 	if (length(whoDyin))
 		for (var/mob/living/M in whoDyin)
-			admin_ticket_log(M, "[key_name_admin(usr)] [msg]")
+			admin_ticket_log(M, msg)


I wouldn't do this, as this removes the user who launched the pod from the log.

Not at my computer rn, but I'm pretty sure I'm grabbing usr in the New of the ticket log. I will check when I can

It won't necessarily be the same usr who's launching the pod, though...

admin_ticket_log doesn't pass a ckey, so /datum/ticket_log/New will set the user variable to get_fancy_key(usr) which is the same usr variable this call was passing to key_name_admin

LikeLakers2 · 2025-03-12T08:37:13Z

code/modules/mob/living/carbon/carbon.dm

@@ -1141,20 +1141,20 @@
 				if("remove")
 					if(BP)
 						BP.drop_limb()
-						admin_ticket_log("[key_name_admin(usr)] has removed [src]'s [parse_zone(BP.body_zone)]")
+						admin_ticket_log("[key_name(usr)] has removed [src]'s [parse_zone(BP.body_zone)]")


Why are we switching this from key_name_admin to key_name...?

LikeLakers2 · 2025-03-12T08:50:00Z

interface/skin.dmf

Could I recommend not changing the interface skin, and instead adding the "Tickets" button under the "Admin" tab, like we already have with "View Latest Ticket"?

The interface button is convenient and works for players and admins, much easier than finding a verb every time

But we already have a tab where ticket stuff can be found - where players and admins alike would expect it to be. There is no reason to put the new stuff in a different place.

with discord verification, the tickets tab will become even more empty and obsolete because we're yoinking interviews. I think the tickets button is a nice addition.

tired-wired · 2025-03-22T22:27:14Z

Looks all good from an admin perspective.

Absolucy · 2025-03-23T05:24:59Z

marking as do not merge until the code's thoroughly gone over and approved.

it's okay to testmerge, tho

flleeppyy · 2025-03-28T00:46:09Z

monkestation/code/modules/admin/verbs/ticketpanel.dm

+		if("Notes")
+			browse_messages(target_ckey = ticket.initiator_ckey)
+			return


There's a ui act for notes but no button on the ui for it?

flleeppyy · 2025-03-28T00:46:44Z

Admins would like to be able to see how long ago a ticket was opened like on the old panel

Admins would also like further clarification on the "Administer", perhaps a tooltip or a rename to "Claim" would be good

flleeppyy · 2025-03-28T01:10:02Z

A quick guide for admins would be nice! Something like a question mark button in the top right of the window that sends something like:

<div class="boxed_message"><b>TGUI Ticket Panel</b><br><span class="notice">
The new ticket interface takes a new approach to tickets; getting rid of the old tickets tab and giving it a new home as a button in the top right corner of the interface. You'll no longer have to refresh tickets to update them, since TGUI does that for you.<br><br></span>
<b>Rundown</b>
<br>
<span class="notice">
There are now 3 tabs at the top that act as a filter, each with 3 collapsible categories. "All", "My Tickets", "Unclaimed" and 3 categorys; namely Active, closed and resolved. All are self-explanatory.<br>
Tickets can now be claimed by an admin by pressing "Administer" on tickets, so less stepping on toes.<br>
Each ticket now has a chatbox that updates <i>live</i> as messages are sent.<br>
The ticket controls are pretty much the same compared to classic tickets.
</span>

</div>

Can be achieved with

chatRenderer.processBatch([{html: `blahblah`}])

BanementI · 2025-03-28T21:16:15Z

can we also have the ticket reply box be bigger? sometimes responses are long as hell and its annoying not being able to see the entire paragraph we gotta send

LikeLakers2 added Feature: enhancement New feature or request Approval: awaiting admin review PR is awaiting admin approval Code: TGUI Involves TGUI in some way, shape or form labels Mar 12, 2025

LikeLakers2 suggested changes Mar 12, 2025

View reviewed changes

LikeLakers2 reviewed Mar 12, 2025

View reviewed changes

tired-wired added Approval: admin approved PR is approved by admins and removed Approval: awaiting admin review PR is awaiting admin approval labels Mar 22, 2025

Absolucy added Process: do not merge don't merge this ffs Process: should testmerge PR should be testmerged first labels Mar 23, 2025

github-actions bot added the Merge Conflict DO NOT RENAME THIS LABEL label Mar 27, 2025

adamsong force-pushed the tgui-ticket-panel branch from ca7c87b to f30c516 Compare March 27, 2025 02:02

github-actions bot added Merge Conflict DO NOT RENAME THIS LABEL and removed Merge Conflict DO NOT RENAME THIS LABEL labels Mar 27, 2025

adamsong force-pushed the tgui-ticket-panel branch from cad5070 to 2fdcd12 Compare March 27, 2025 17:57

MonkestationIssueBot mentioned this pull request Mar 27, 2025

Misleading, deadly chutes on Lead #6085

Open

github-actions bot removed the Merge Conflict DO NOT RENAME THIS LABEL label Mar 27, 2025

flleeppyy reviewed Mar 28, 2025

View reviewed changes

MonkestationIssueBot mentioned this pull request Mar 28, 2025

Curator console bug #6092

Open

This was referenced Mar 28, 2025

Polyglot giving Common #6094

Closed

Two photocopiers in the Hops Office in Pubbystation #6095

Closed

Infinite disposal water tank glitch #6096

Open

challenges don't give extra monkecoin #6097

Open

Invisible sentient plush #6100

Open

adamsong added 10 commits April 12, 2025 11:27

Ports tgui ticket panel from yogs

c1b1a28

Fix lints

99740a0

Reorder dme, do tgui linting

88f44a2

Make adjustments for comments

3338e93

Unhides the tickets verb so it can be typed in the command bar

8ba125d

Addresses issues

39fe2d9

Lint

f532706

Made replay link a config

0e3706b

Forgot I needed to add this, oops

dd044b6

Handle plexora replies better

d101862

adamsong force-pushed the tgui-ticket-panel branch from fb511db to d101862 Compare April 12, 2025 15:27

Absolucy approved these changes Apr 12, 2025

View reviewed changes

Absolucy merged commit 8e53da3 into Monkestation:master Apr 12, 2025
25 checks passed

Absolucy removed the Process: do not merge don't merge this ffs label Apr 12, 2025

github-actions bot added a commit that referenced this pull request Apr 12, 2025

Automatic changelog for PR #5906 [ci skip]

51b1be3

MonkestationIssueBot mentioned this pull request Apr 12, 2025

microwaved airlock emag is invisible #6317

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports tgui ticket panel from yogs #5906

Ports tgui ticket panel from yogs #5906

adamsong commented Mar 12, 2025 •

edited by github-actions bot

Loading

michaelyoungin commented Mar 12, 2025

LikeLakers2 commented Mar 12, 2025 •

edited

Loading

LikeLakers2 Mar 12, 2025

adamsong Mar 12, 2025

Absolucy Mar 12, 2025

LikeLakers2 Mar 12, 2025 •

edited

Loading

adamsong Mar 16, 2025

LikeLakers2 Mar 12, 2025

LikeLakers2 Mar 12, 2025 •

edited

Loading

adamsong Mar 16, 2025

LikeLakers2 Mar 12, 2025

adamsong Mar 16, 2025

LikeLakers2 Mar 12, 2025

adamsong Mar 12, 2025 •

edited

Loading

LikeLakers2 Mar 12, 2025 •

edited

Loading

adamsong Mar 16, 2025

LikeLakers2 Mar 12, 2025

LikeLakers2 Mar 12, 2025

adamsong Mar 12, 2025

LikeLakers2 Mar 12, 2025 •

edited

Loading

flleeppyy Mar 28, 2025

tired-wired commented Mar 22, 2025

Absolucy commented Mar 23, 2025 •

edited

Loading

flleeppyy Mar 28, 2025

flleeppyy commented Mar 28, 2025 •

edited

Loading

flleeppyy commented Mar 28, 2025 •

edited

Loading

BanementI commented Mar 28, 2025

Ports tgui ticket panel from yogs #5906

Ports tgui ticket panel from yogs #5906

Conversation

adamsong commented Mar 12, 2025 • edited by github-actions bot Loading

About The Pull Request

Why It's Good For The Game

Changelog

michaelyoungin commented Mar 12, 2025

LikeLakers2 commented Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LikeLakers2 Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LikeLakers2 Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamsong Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

LikeLakers2 Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LikeLakers2 Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tired-wired commented Mar 22, 2025

Absolucy commented Mar 23, 2025 • edited Loading

Choose a reason for hiding this comment

flleeppyy commented Mar 28, 2025 • edited Loading

flleeppyy commented Mar 28, 2025 • edited Loading

BanementI commented Mar 28, 2025

adamsong commented Mar 12, 2025 •

edited by github-actions bot

Loading

LikeLakers2 commented Mar 12, 2025 •

edited

Loading

LikeLakers2 Mar 12, 2025 •

edited

Loading

LikeLakers2 Mar 12, 2025 •

edited

Loading

adamsong Mar 12, 2025 •

edited

Loading

LikeLakers2 Mar 12, 2025 •

edited

Loading

LikeLakers2 Mar 12, 2025 •

edited

Loading

Absolucy commented Mar 23, 2025 •

edited

Loading

flleeppyy commented Mar 28, 2025 •

edited

Loading

flleeppyy commented Mar 28, 2025 •

edited

Loading