Fix the Experimental Destructive Scanner's UI #5876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. it's just two lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Somehow, the Experimental Destructive Scanner's UI is broken over here on Monke. Specifically, the scrollbar in the Experiments section doesn't appear to show on 516.
Notably, the same tgui code (or seemingly the same code) doesn't appear to break over on tgstation, indicating a possible discrepancy between React and Inferno and how they handle WebView2.
As such, I have marked it as something to investigate when we eventually get to porting to React.
Before
After
Why It's Good For The Game
Fixes #5875
Changelog
🆑MichiRecRoom
fix: The experimental destructive scanner's UI should now show a scrollbar on 516. (Please let me know if any other UIs that show a list of experiments are broken.)
/:cl: