Skip to content

Prevent duplicated objects in important_recursive_contents #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Mar 7, 2025

About The Pull Request

Port of my own upstream PR, tgstation/tgstation#89819

This fixes a bug introduced back in tgstation/tgstation#66709 that could cause the same object to appear in important_recursive_contents multiple times if become_hearing_sensitive was called multiple times, most commonly with the broadcast camera's entertainment channel microphone.

Before

2025-03-04 (1741121218) ~ dreamseeker

After

2025-03-04 (1741121797) ~ dreamseeker

Why It's Good For The Game

because hearing every message twice when the curator is streaming is annoying

Changelog

🆑
fix: Fixed some hearing sensitive objects hearing the same thing multiple times, such as the broadcast camera sending everything to the entertainment channel twice.
/:cl:

@Absolucy Absolucy added the Code: Fix fix da bug label Mar 7, 2025
@Absolucy Absolucy merged commit 36f9196 into Monkestation:master Mar 8, 2025
28 checks passed
@Absolucy Absolucy deleted the fix-radio-dupe-port branch March 8, 2025 04:12
github-actions bot added a commit that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Fix fix da bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant