-
Notifications
You must be signed in to change notification settings - Fork 345
Revenant Blight Rework #5839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Revenant Blight Rework #5839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on2.0-privfixes into revblightrework
Absolucy
requested changes
Mar 7, 2025
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_abilities.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_abilities.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_abilities.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
This was referenced Mar 8, 2025
Closed
This was referenced Mar 10, 2025
Open
Absolucy
requested changes
Mar 11, 2025
monkestation/code/modules/mob/living/basic/space_fauna/revenant/revenant_effects.dm
Outdated
Show resolved
Hide resolved
This was referenced Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Cherry-picked from Absolucy Commit
Continued from the base change @Absolucy has started, this PR finishes moving Revenant's Blight effects from a disease into a status effect. This returns the Revenants stamina draining and bad luck effects back to the ability. It also lowers the severity of the damage received by the bad luck effects. Stamina drains were adjusted to compensate for monkestation stamina. Finally due to the changes the effects now run on a 5 minute timer that refreshes every time the Revenant applies the AOE to you. This refresh also increases the severity of the effects it also now takes into account sleeping for chances to cure and now holy water in your system will reduce the status by 5 seconds each proc. Once cured a 1 minute blight protection is applied to you to keep from being blighted immediately after healing from it.
Why It's Good For The Game
The Revenant's Blight ability doesn't really do anything which makes it a waste of points due to the pathology changes. This just moves it over to a status effect as it seems more thematic and better supported by the background code. This will still need balance adjustments as the tox and stamina damage seems rather weak.
Changelog
🆑Siro, Lucy
add: Blight Protection status effect applied after being cured of Blight.
bal: Stamina damage adjusted to monkestation changes.
qol: Blight cure now checks for active sleeping instead of just laying down. Gives chance for essence absorption.
fix: Blight now applies its debuffs again.
code: Blight debuff effects converted from a disease to a refreshing status effect.
/:cl: