Skip to content

[BOUNTY] Upgraded Emitters can now tear down walls! #5706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

Singul0
Copy link
Contributor

@Singul0 Singul0 commented Feb 28, 2025

About The Pull Request

This PR makes it so that emitters with upgraded lasers can now be able to tear down walls, stock parts emitters still functions the same. Below are the damage table needed to tear a wall down (this number does not include girders)

T1 laser: cannot damage walls, operates normally.
T2: 20 hits to break normal walls, r wall or stronger cannot be damaged.
T3: 10 hits to kill normal walls, r wall or stronger cannot be damaged.
T4: 5 hits to kill normal walls, r walls or strong take 18 hits to be killed.
T5: 3 hits to kill normal, 10 to kill r walls or higher

Emagging the emitters increases the parts tier above by one (which is how you'd get T5) at the cost of 5% damage to the emitters. This functionality only applies if the projectile emitted by the emitters is the default hitscan emitters shots.

Why It's Good For The Game

You know how the emitters looks like a heavy, industrial laser cannon that you'd be able to see be used as an impromptu blaster? How come can it not damage walls? Anyways, this adds a new way of breaching walls besides thermite, tools or c-4/x-4, Albeit a pretty slow and loud one at that. More tools for engineer's arsenal is good!

Changelog

🆑
add: Emitters can now tear down walls! (once upgraded)
/:cl:

@Singul0
Copy link
Contributor Author

Singul0 commented Feb 28, 2025

I tried linking wall integrity with atom_integrity, but it caused me too much headache with other things messing with it. hopefully this implementation isn't that bad.

@LikeLakers2 LikeLakers2 added Feature: enhancement New feature or request Feature: Feature The creature feature. featuring: the creature. and removed Feature: enhancement New feature or request labels Feb 28, 2025
@Veth-s Veth-s added the Approval: admin approved PR is approved by admins label Mar 6, 2025
@wraith-54321
Copy link
Collaborator

might need to change interactions with blob

@Absolucy
Copy link
Member

Absolucy commented Mar 7, 2025

this breaks welding down walls

@ThePooba
Copy link
Collaborator

ThePooba commented Mar 7, 2025

I cant merge this it would cause too many balance issues

@ThePooba ThePooba closed this Mar 7, 2025
ThePooba pushed a commit that referenced this pull request Mar 23, 2025
… Upgraded Emitters can now tear down walls! Take Two! (#5938)

## About The Pull Request
Ports yogstation13/Yogstation#21336
Retake of #5706
This PR is a double bounty, makes it so that walls behaves the same way
as any other structures or machineries, being able to be damaged and
destroyed by normal weapons instead of very specific ways/deconstruction

Normal walls have 300 damage + armor, with a damage minimum for it to
take effect of 25
Normal walls have 600 damage + armor, with a damage minimum for it to
take effect of 75

Emitters with upgraded lasers can now be able to tear down walls, stock
parts emitters still functions the same. Below are the damage table
needed to tear a wall down

T1 laser: cannot damage walls, operates normally.
T2: 20 hits to break normal walls, r wall or stronger cannot be damaged.
T3: 10 hits to kill normal walls, r wall or stronger cannot be damaged.
T4: 5 hits to kill normal walls, r walls or strong take 10 hits to be
killed.
T5: 3 hits to kill normal, 7 to kill r walls or higher
Emagging the emitters increases the parts tier above by one (which is
how you'd get T5) at the cost of 5% damage to the emitters. This
functionality only applies if the projectile emitted by the emitters is
the default hitscan emitters shots.

Pooba said that for my first PR to go through, we'd need to implement
atom integrity, which they'd gracefully posted a bounty for.
## Why It's Good For The Game
Here is it in action:

https://github.com/user-attachments/assets/34b999b0-a7f6-4fa7-ac26-5e804e3ba5ad

Walls being able to use the integrity system means destroying them in a
way that isn't instantaneous and no longer needs to rely on tons of
snowflake code for each instance/case of something breaking a wall. It
also means they aren't totally invincible to damage, which I think could
allow for some fun interactions.

Anyhow, as for the emitter PR. i'll just copy this verbatim: You know
how the emitters looks like a heavy, industrial laser cannon that you'd
be able to see be used as an impromptu blaster? How come can it not
damage walls? Anyways, this adds a new way of breaching walls besides
thermite, tools or c-4/x-4, Albeit a pretty slow and loud one at that.
More tools for engineer's arsenal is good!
## Changelog
:cl:
add: Walls now have atom integrity, being able to be attacked and
destroyed like other machineries and structures. they're a tough nut to
crack though
 add: Emitters can now tear down walls! (once upgraded)
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approval: admin approved PR is approved by admins Feature: Feature The creature feature. featuring: the creature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants