Small credits refactor #5660
Merged
Small credits refactor #5660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitsunemitsu
added
the
Feature: Refactor/Rework
Absolucy
added
the
Code: Performance / Optimization
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Right now, every
/atom/movable/screen/creditis duplicated for every client that doesn't have credits disabled.This results in a lot of objects being created and deleted every second while credits are rolling.
I think it was coded this way to support different viewport sizes, but it doesn't actually work(?).
This PR massively reduces the total amount of created objects, while maintaining the same look.
Also, credits now properly adjust their position when player's viewport size changes.
Example
New.-.Smallest.mp4
Why It's Good For The Game
Less lag during round-end.
Changelog
🆑
refactor: Credits have been slightly refactored. This should result in increased perfomance during the end of the round.
/:cl: