/mob/living/infect_disease() now compares the uniqueID and subID directly
#5484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeLakers2
added
Code: Performance / Optimization
LikeLakers2
changed the title
/mob/living/infect_disease now compares the uniqueID and subID directly/mob/living/infect_disease() now compares the uniqueID and subID directly
This was referenced Feb 17, 2025
Closed
LikeLakers2
deleted the
project/small-opt/why-was-this-comparing-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Previously, this line concatenated the unique ID and sub ID into a string, and compared that.
However, the use of a string here was completely unnecessary, and we could just compare the values directly, which is infinitely faster.
Why It's Good For The Game
performance number go up weeee
Changelog
N/A no player-facing changes