Skip to content

[PORT] Changes entertainment radio to be darker #5483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LikeLakers2
Copy link
Collaborator

This PR is a port of the following PR from tgstation:

Before I show the original PR description, here's an example of what our entertainment radio messages currently look like:
image
image

Original PR description follows:

About The Pull Request

I made the entertainment radio text a little less eye-searing.

380234524-d95c10aa-cfa1-4365-922b-b3a5c03e3bfd
380234533-aed97d39-2938-4fdb-8ccc-930a65deb592
380326969-436632c1-59eb-4fb4-a632-0c3b2448e45a

Why It's Good For The Game

I'm sure it looked kind of okay on dark mode, but for us light mode heathens, entertainment chat could be kind of hard to read sometimes. This shade looks better and, while not as bright, I think fits the role better - I went for something similar to the kind of blue/grey of a reporter's suit.

Changelog

🆑MichiRecRoom, Vekter
fix: Changed the color of entertainment radio to be darker
/:cl:

I made the entertainment radio text a little less eye-searing.

![image](https://github.com/user-attachments/assets/d95c10aa-cfa1-4365-922b-b3a5c03e3bfd)

![image](https://github.com/user-attachments/assets/aed97d39-2938-4fdb-8ccc-930a65deb592)

![image](https://github.com/user-attachments/assets/436632c1-59eb-4fb4-a632-0c3b2448e45a)

I'm sure it looked kind of okay on dark mode, but for us light mode
heathens, entertainment chat could be kind of hard to read sometimes.
This shade looks better and, while not as bright, I think fits the role
better - I went for something similar to the kind of blue/grey of a
reporter's suit.
:cl: Vekter
fix: Changed the color of entertainment radio to be darker
/:cl:
@LikeLakers2 LikeLakers2 added Severity: Minor Tweak change a thing to work a little different labels Feb 16, 2025
@LikeLakers2 LikeLakers2 changed the title [PORT] Changes entertainment radio to be darker (#87459) [PORT] Changes entertainment radio to be darker Feb 16, 2025
Copy link
Member

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is fine, and i like this change myself

@Absolucy Absolucy merged commit cd66866 into Monkestation:master Feb 16, 2025
28 checks passed
github-actions bot added a commit that referenced this pull request Feb 16, 2025
@LikeLakers2 LikeLakers2 deleted the project/port/tg-87459-entertainment-radio-on-light-mode branch February 16, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Minor Tweak change a thing to work a little different
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants