Skip to content

Small IPC Fixes #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 26, 2025
Merged

Small IPC Fixes #5396

merged 11 commits into from
Feb 26, 2025

Conversation

Ziiro
Copy link
Contributor

@Ziiro Ziiro commented Feb 10, 2025

About The Pull Request

This is one step on a long road of doing stuff to differentiate/fix IPCs while not immediately affecting material balance concerns. I have other fixes and ideas for balance, however I am going to keep chipping away at this piecemeal.

Why It's Good For The Game

This fixes a few small problems with IPCs that are general usability problems, as well as updates their language pool to maintain their status as "universal translator" with a number of languages.

This also sets robotic limbs to spark when struck, giving it a cooler visual flavor in fights with IPCs & augmented crew.

Changelog

🆑
fix: The IPC posibrains are now stored in the chest.
fix: The IPC "Change Display" action now allows you to also change the color.
fix: IPC tongues have been moved from the head to the mouth
fix: IPC tongues now have have no tastes - liked, disliked, or toxic. (previously was inheriting human tastes)
balance: IPCs now speak more languages to resume their role as a universal translator
add: Robotic limbs now spark when struck by objects with enough force
/:cl:

@Ziiro Ziiro changed the title Small IPC Fixes - Moves brain to chest, fixes color selection of monitor Small IPC Fixes Feb 10, 2025
@Donkier
Copy link

Donkier commented Feb 10, 2025

does the is mean headless IPCs are back?

@Ziiro
Copy link
Contributor Author

Ziiro commented Feb 10, 2025

does the is mean headless IPCs are back?

dreamseeker_eInqW9JJju

Obviously it makes you blind, incomprehensible to speak with, and unable to hear, but yes.

@Veth-s Veth-s added Feature: enhancement New feature or request Feature: Expansion Some addons for a big new thing labels Feb 11, 2025
@github-actions github-actions bot added the Merge Conflict DO NOT RENAME THIS LABEL label Feb 14, 2025
@Ziiro
Copy link
Contributor Author

Ziiro commented Feb 21, 2025

Hitting robotic limbs with objects that have enough force now generates sparks
dreamseeker_sHlMkeGO8l

@Ziiro Ziiro marked this pull request as ready for review February 22, 2025 02:24
@github-actions github-actions bot removed the Merge Conflict DO NOT RENAME THIS LABEL label Feb 22, 2025
@Ziiro
Copy link
Contributor Author

Ziiro commented Feb 26, 2025

Discovered some issues

  • Standard Revival surgery currently causes all of the organs to explode out of an IPC, this should be blocked (there's a posibrain reboot option)
  • posibrains can be shoved into heads directly, probably need to check ORGAN_SLOT for the attackby of putting brains in heads

@Ziiro
Copy link
Contributor Author

Ziiro commented Feb 26, 2025

That should fix those. I'm hesitant to call them solid fixes, but they aren't exactly the hackiest thing I've done.

  • Revival no longer appears for MOB_ROBOTIC (we already have that, it's positronic restoration)
  • Attempting to shove a brain that does not belong in the head will now no longer be possible, and tell the user the issue.

Tested and confirmed that these behaviors work just fine when dealing with organic carbons

@ThePooba ThePooba merged commit cb5c483 into Monkestation:master Feb 26, 2025
25 checks passed
github-actions bot added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: enhancement New feature or request Feature: Expansion Some addons for a big new thing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants