Fix smite ignoring antimagic, also tell the caster what the smite was #5390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeLakers2
reviewed
Feb 10, 2025
Co-authored-by: MichiRecRoom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #5360
this makes it so smite will fail if the target has antimagic (either normal antimagic, or holy antimagic)
also makes it so the caster which smite was used.
Why It's Good For The Game
bugfix, and just a minor qol so it doesn't seem like nothing happened with certain smites.
Changelog
🆑
fix: Smite (the spell) is now properly blocked by antimagic.
qol: Smite now tells the caster which smite was inflicted.
/:cl: