Fix food buffs potentially resulting in negative stamina #4908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraith-54321
approved these changes
Jan 17, 2025
This was referenced Jan 19, 2025
This was referenced Jan 20, 2025
Closed
Closed
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I somehow ended up with a maximum stamina of -650, and after code diving - the only thing that ever sets
stamina.maximumis food buffs. So I decided to clean up some of that code a bit, and add a new wrapper,/datum/stamina_container/proc/set_maximum, which ensures that the maximum value is never 0 or below.Why It's Good For The Game
mrrrp mrrp mrrow :3
Changelog
🆑
fix: Fixed food buffs potentially resulting in negative maximum stamina, resulting in permanent slowdown.
/:cl: