Skip to content

Ore Processing QOLs #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2025
Merged

Ore Processing QOLs #4789

merged 5 commits into from
Jan 11, 2025

Conversation

Coll6
Copy link
Contributor

@Coll6 Coll6 commented Jan 8, 2025

About The Pull Request

A lot of the machines that process ores are not explained on how they function. Not only that the tool tips are plain wrong for some causing confusion. Also several minor bugs present throughout the whole system. This attempts to address some issues. First it corrects the tooltips. Now they correctly display what machine they are what they will take and process. Second this allows all the machines to be hand fed the materials they accept. Previously they would only take items fed on belts. Third, the final refinery machines(Refinery and Smelter) no longer delete or dust if they are made of the wrong materials. This here has spawned a lot of confusion. They see dust enter the machines and disappear but get no points from it. This has led a few to believe the machines are broken, or the dust ores do not produce anything. In fact the smelter which only process metals was given plastic and thus it deleted the material. Now the dust will be treated much like boulders and will be spit out if materials in the dust cannot be processed by that machine.

Why It's Good For The Game

Lot of this game can be confusing enough as it is, cant have items displaying the wrong information. Also hopefully with the machines correctly labeled and explaining what they take and output it might make people start using them.

Changelog

🆑Siro
qol: Tooltips now properly state the ore machines description and what it will accept. Will also show pipe connections if applicable.
qol: Machines can now be hand fed the items it processes. Artifact boulders drop artifacts on all production machines.
fix: Ore dust no longer deleted in the final refinery(Refinery/Smelter) machines.
fix: Amalgams will now properly jam machines.
fix: Maintenance hatch now properly displays its open status.
/:cl:

@DexeeXI DexeeXI added QoL improves quality of life fuck it we ball what could possibly go wrong? labels Jan 8, 2025
@DexeeXI
Copy link
Collaborator

DexeeXI commented Jan 8, 2025

descriptions on how factorio + mekanism works seems like a fun idea to me.

@Coll6
Copy link
Contributor Author

Coll6 commented Jan 10, 2025

There is a huge bug I found while going though the system. Stage 5 ore processing deletes materials. No idea how to even address it yet.

@ThePooba ThePooba merged commit a19b3fd into Monkestation:master Jan 11, 2025
25 checks passed
github-actions bot added a commit that referenced this pull request Jan 11, 2025
@Coll6 Coll6 mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuck it we ball what could possibly go wrong? QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants